Skip to content

docs(proofs): clarify verification scope of attestation and proof verification - #243

Merged
emostov merged 1 commit into
mainfrom
zeke/proof-verification-doc-warnings
Aug 14, 2026
Merged

docs(proofs): clarify verification scope of attestation and proof verification#243
emostov merged 1 commit into
mainfrom
zeke/proof-verification-doc-warnings

Conversation

@emostov

@emostov emostov commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

What

Docs-only change to proofs/src/lib.rs (rustdoc comments; no behavior changes):

  • parse_and_verify_aws_nitro_attestation / parse_and_verify_der_attestation: add warnings that these verify AWS Nitro PKI/COSE authenticity only and do not validate PCR identity, user_data, or manifest policy against expected/pinned values.
  • verify(app_proof, boot_proof): document its actual scope (AWS attestation, envelope approval self-consistency, manifest/user_data linkage, ephemeral-key linkage, PCR0-3/PCR17 vs the supplied manifest) and warn that the supplied manifest contents, manifest-set members, and threshold are NOT compared to an independently pinned Turnkey trust anchor.
  • Fix stale rustdoc link in unsafe_attestation_doc_from_der (attestation_doc_from_der -> parse_and_verify_der_attestation).

All warnings point to https://github.com/tkhq/qos for the canonical verification checks.

Verification

cargo fmt --check
cargo test -p turnkey_proofs   # 5 unit tests + 1 doctest pass
cargo doc -p turnkey_proofs --no-deps   # no warnings

@emostov
emostov force-pushed the zeke/proof-verification-doc-warnings branch from 7f111b7 to c65ce7c Compare August 14, 2026 23:20
@emostov
emostov marked this pull request as ready for review August 14, 2026 23:22

@lreading-turnkey lreading-turnkey left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@emostov
emostov merged commit c2b202f into main Aug 14, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants