Skip to content

feat(embeddings): support Ollama context options#74

Open
senamakel wants to merge 1 commit into
mainfrom
feat/openhuman-embedding-options
Open

feat(embeddings): support Ollama context options#74
senamakel wants to merge 1 commit into
mainfrom
feat/openhuman-embedding-options

Conversation

@senamakel

@senamakel senamakel commented Jul 22, 2026

Copy link
Copy Markdown
Member

Summary

  • Adds optional Ollama num_ctx and num_batch request options to the shared embedding model.
  • Exposes the recommended 8192-token context constant used by OpenHuman.
  • Improves missing-model failures with an actionable ollama pull command.
  • Preserves existing defaults when the new options are not configured.

API Or Behavior Changes

OllamaEmbeddingModel gains optional context and batch fields plus builder methods. Existing callers retain the prior wire shape; configured callers add the corresponding Ollama options.

Tests

Focused validation completed:

  • cargo test harness::embeddings -- --test-threads=1 (38 passed)

  • Exercised through OpenHuman CI Full run 29925645209

  • cargo fmt --check

  • cargo clippy --all-targets -- -D warnings

  • cargo clippy --all-targets --all-features -- -D warnings

  • cargo build --all-targets

  • cargo build --all-targets --all-features

  • cargo test

  • cargo test --all-features

Documentation

The public constant and builder methods are documented inline. No standalone documentation change is needed.

@coderabbitai

coderabbitai Bot commented Jul 22, 2026

Copy link
Copy Markdown

Warning

Review limit reached

You’ve reached a temporary PR review limit under our Fair Usage Limits Policy.

Your recent review volume is higher than typical usage, so adaptive limits are currently applied.

Next review available in: 40 minutes

Enable usage-based reviews in Billing to review now. Otherwise, wait until the next included review is available.
You're only billed for reviews past your plan's rate limits ($0.25/file).

How can I continue?

After more reviews become available, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

To avoid repeated limits, reduce automatic review volume by pausing incremental auto-reviews earlier, using label-based review opt-in, excluding WIP or generated PR titles, or requesting reviews manually when the PR is ready. If your team needs uninterrupted high-volume reviews, an organization admin can enable usage-based reviews.

How do review limits work?

CodeRabbit enforces per-developer PR review limits for each organization. Most developers receive the normal plan review availability.

For paid Pro and Pro+ PR reviews, CodeRabbit uses adaptive limits for sustained high-volume activity. When a developer's recent PR review activity reaches the 95th percentile or higher among CodeRabbit users, additional reviews become available more gradually as earlier reviews age out of the rolling window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Run ID: e408eaca-3dcd-4a89-8733-a92663901a34

📥 Commits

Reviewing files that changed from the base of the PR and between 2583fcc and 07467c3.

📒 Files selected for processing (2)
  • src/harness/embeddings/mod.rs
  • src/harness/embeddings/ollama.rs

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant