Skip to content

chore(ci): validate post-merge full suite - #5475

Merged
senamakel merged 27 commits into
tinyhumansai:mainfrom
senamakel:openhuman-ci-followup
Aug 10, 2026
Merged

chore(ci): validate post-merge full suite#5475
senamakel merged 27 commits into
tinyhumansai:mainfrom
senamakel:openhuman-ci-followup

Conversation

@senamakel

@senamakel senamakel commented Aug 10, 2026

Copy link
Copy Markdown
Member

Draft verification branch following the merge of #5469.\n\n- Base: current upstream/main\n- Full local frontend and Rust suites are running\n- Full GitHub Actions workflow: https://github.com/senamakel/openhuman/actions/runs/31370196995\n\nAny follow-up CI/E2E repair will be added here.

Summary by CodeRabbit

  • Bug Fixes

    • Preserved access to the Accounts page through the /accounts route by redirecting it to Chat.
    • Improved panel keyboard and outside-click behavior.
    • Enhanced Windows test resets without disrupting the active WebView session.
  • Tests

    • Expanded route and Accounts page coverage.
    • Improved end-to-end navigation reliability and route validation.
    • Stabilized workspace-dependent and wallet address tests.

Co-authored-by: Medulla <medulla@tinyhumans.ai>
@coderabbitai

coderabbitai Bot commented Aug 10, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

Caution

Review failed

The pull request is closed.

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 8b963450-44d8-4784-987d-09ae02ed8c7d

📥 Commits

Reviewing files that changed from the base of the PR and between 48e372e and 922719c.

⛔ Files ignored due to path filters (1)
  • app/src-tauri/Cargo.lock is excluded by !**/*.lock
📒 Files selected for processing (11)
  • .github/workflows/test-reusable.yml
  • app/src-tauri/src/process_recovery.rs
  • app/src/AppRoutes.auth.test.tsx
  • app/src/AppRoutes.tsx
  • app/src/components/intelligence/ObsidianVaultSection.tsx
  • app/test/e2e/helpers/reset-app.ts
  • app/test/e2e/helpers/shared-flows.ts
  • app/test/e2e/specs/coding-session-memory.spec.ts
  • src/core/dispatch.rs
  • src/openhuman/web3/wallet/chains/btc.rs
  • src/openhuman/web3/wallet/execution.rs

📝 Walkthrough

Walkthrough

The changes update Rust test isolation, legacy application routes, E2E navigation helpers, Windows renderer reset behavior, UI effect timing, workspace test setup, and wallet validation data and logging.

Changes

Application navigation and E2E routing

Layer / File(s) Summary
Legacy route compatibility
app/src/AppRoutes.tsx, app/src/AppRoutes.auth.test.tsx
/accounts now redirects to /chat. Route tests verify the Accounts page behavior.
E2E route mapping and readiness
app/test/e2e/helpers/shared-flows.ts
E2E helpers add legacy redirects and require the resolved hash when no route-ready selector exists.
Platform-specific E2E reset
app/test/e2e/helpers/reset-app.ts, app/test/e2e/specs/coding-session-memory.spec.ts
Windows resets avoid document reloads. The coding-session-memory flow waits for the post-login home route.

Rust test reliability

Layer / File(s) Summary
Isolated JSON-RPC test execution
.github/workflows/test-reusable.yml
json_rpc_e2e tests run individually in isolated Cargo processes with exact matching and one test thread.
Workspace environment isolation
src/core/dispatch.rs
A test-only guard serializes OPENHUMAN_WORKSPACE access and restores its prior value. The tier-2 dispatch test uses the guard.

UI listener lifecycle

Layer / File(s) Summary
Expanded-panel listener lifecycle
app/src/components/intelligence/ObsidianVaultSection.tsx
Panel dismissal listeners now use useLayoutEffect while retaining existing dismissal and cleanup behavior.

Wallet and platform maintenance

Layer / File(s) Summary
Wallet validation diagnostics and test data
src/openhuman/web3/wallet/chains/btc.rs, src/openhuman/web3/wallet/execution.rs
The Bitcoin test uses a different testnet address. Wallet-chain logging uses debug formatting.
macOS process-recovery cleanup
app/src-tauri/src/process_recovery.rs
The unused std::fs import is removed.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Possibly related PRs

Suggested reviewers: m3ga-mind

Poem

A rabbit checks each test in line,
While routes resolve in proper time.
Windows keeps its session near,
Wallet logs grow crisp and clear,
And unused imports disappear.

✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

senamakel and others added 26 commits August 10, 2026 12:19
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Co-authored-by: Medulla <medulla@tinyhumans.ai>
When running E2E tests with Tauri on Linux, a previous driver process may still hold the listening socket after its parent shell exits. The readiness probe against the default port would then incorrectly report the old driver as ready, causing WebDriverIO to connect to a stale session manager and eventually time out. This change detects an occupied default port and falls back to an ephemeral port, ensuring the readiness probe always identifies the newly launched driver.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The WebView2 configuration for EdgeDriver now includes the `useWebView` option set to true, which selects the native renderer target instead of an empty browser-style DevTools target. This ensures EdgeDriver attaches to the correct webview instance when using the debugger address.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Collapsed the `ms:edgeOptions` object into a single line to improve readability and reduce unnecessary vertical space in the WebDriverIO configuration.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The WebDriverIO before hook that selects the correct browser window by filtering window handles now returns early on Windows. EdgeDriver's WebView2 session already targets the application renderer, and its window-handle list includes a synthetic blank document that would otherwise cause the generic CDP-target selection to switch the session away from the app.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The closing `*/` comment marker in the `before` hook's JSDoc block was missing a leading space, breaking the comment formatting. This change adds the missing space to align the closing marker with the rest of the comment block.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The WebDriverIO configuration for Edge now includes the `windowTypes` option set to `['webview']` alongside the existing `debuggerAddress`. This ensures that EdgeDriver exposes native WebView handles for Tauri's renderer instead of only its synthetic browser target.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Remove the heuristic that accepted a stabilised but unrelated hash as evidence of navigation completion. This heuristic could mask failed route changes, such as a test continuing on `/chat` after attempting to navigate to `/brain?tab=sources`. The resolved target hash is now required directly, since redirects are already accounted for when computing the expected hash.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add a route redirect for the retired standalone accounts view, preserving any existing bookmarks or links that point to /accounts. The redirect sends users to the chat page, which now serves as the primary landing area. Also update the end-to-end test helper to include the new redirect mapping, ensuring automated tests remain consistent with the routing change.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Add a test that verifies the retired `/accounts` route renders the accounts page component, ensuring the redirect to unified chat works correctly.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
…cortex,vendor/tinyflows

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
…cortex,vendor/tinyflows

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The redirect for /routines was changed from /settings/automations to /flows, and the separate /workflows redirect was removed as it is no longer needed.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
…cortex,vendor/tinyflows

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
…cortex,vendor/tinyflows

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Added three new hash redirects for the settings pages for LLM, voice, and search to their corresponding tabs in the connections page, ensuring that navigating to these settings URLs correctly resolves to the appropriate section of the connections interface.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The validate_address function now formats the chain parameter with the debug specifier in both log messages, ensuring the enum variant is printed instead of its Display output. This makes the logs more informative when debugging address validation across different wallet chains.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
The Cargo.lock file was updated to reflect the addition of the tinydocs and tinywallet crates as dependencies, while the docx-rs dependency was moved from the main crate to the new tinydocs crate.

Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
Auto-committed-on: dragonfly
Co-authored-by: Medulla <medulla@tinyhumans.ai>
@senamakel
senamakel marked this pull request as ready for review August 10, 2026 16:13
@senamakel
senamakel requested a review from a team August 10, 2026 16:13
@senamakel
senamakel merged commit 64f64f8 into tinyhumansai:main Aug 10, 2026
12 of 17 checks passed
@coderabbitai coderabbitai Bot added rust-core Core Rust runtime in src/: CLI, core_server, shared infrastructure. and removed rust-core Core Rust runtime in src/: CLI, core_server, shared infrastructure. labels Aug 10, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant