Skip to content

Align Bookmarks page chrome with the Resource Vault's look - #111

Merged
timh-dev merged 1 commit into
mainfrom
v3/bookmarks-vault-ui-align
Aug 10, 2026
Merged

Align Bookmarks page chrome with the Resource Vault's look#111
timh-dev merged 1 commit into
mainfrom
v3/bookmarks-vault-ui-align

Conversation

@timh-dev

Copy link
Copy Markdown
Owner

Summary

  • Extracts Vault's scenic paper-card page shell (background photo, scrim, textured paper card with its own scroll region) into a new shared PaperPageShell component, used by both ResourceVaultPage and BookmarksPage — one implementation instead of a bespoke one per page.
  • Restyles the Bookmarks header/toolbar to match Vault's: eyebrow label + serif italic title with a live bookmark count, round back button, and icon-first toolbar buttons (New Folder, Add Bookmark, Import, Export).
  • Adds a search bar to Bookmarks (it had none before) that filters the pill cloud by bookmark name/url or folder title, auto-expanding collapsed folders so matches stay visible.
  • Pills, drag-and-drop reordering, the import dialog, and all pill-level styling are untouched — this is a chrome/shell restyle only, not a rework of the bookmarks interaction model.

Test plan

  • pnpm typecheck — no new errors (only pre-existing, unrelated ones)
  • pnpm test — 203 tests pass, including 6 new tests for the search-filter logic (filterBookmarkTree)
  • Traced drag-and-drop correctness under search filtering: reorder handlers resolve everything by id against the real (unfiltered) tree, never by rendered-list position, so dragging while filtered still lands correctly
  • Visual check in a real browser — not run in this sandbox (missing a system library headless Chromium needs, no sudo available to install it); styling reuses Vault's exact, already-shipped CSS classes verbatim, so risk is low, but worth a quick look before merging

🤖 Generated with Claude Code

Reuses Vault's paper-card page shell, header (eyebrow + serif title +
round back button), and toolbar/search styling on the Bookmarks page,
extracting the shared scene/paper wrapper into a new PaperPageShell
component so both pages use one implementation. Adds a search bar to
Bookmarks (new — it previously had none) that filters the pill cloud
by name/url/folder title, auto-expanding collapsed folders to surface
matches. The pill-cloud layout and drag-and-drop reordering are
unchanged.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@vercel

vercel Bot commented Aug 10, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
startup-page-iebp Ready Ready Preview Aug 10, 2026 12:47am

@timh-dev
timh-dev merged commit baae7ee into main Aug 10, 2026
5 checks passed
@timh-dev
timh-dev deleted the v3/bookmarks-vault-ui-align branch August 10, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant