Drag'n'drop operation confirmations

[eagafonov]

The patch adds a confirmation dialog for most destructive operations, like pushes, removing tags/branches, rebasing.

The rationale for this change is quite silly: my mouse button became flaky and started dropping commits in wrong places when I was rebasing them by drag-and-drop. I was really annoyed with that, and implemented this confirmation dialog.

Some examples:

[eagafonov]

The author date of the original commit is not an error. It is really 6+ y/o. It's time to share it.

[tibirna]

Thank you very much for this. Confirmation of destructive operations is good UX principle. While testing this, I noticed the following:

a) when dropping a patch file (from the file manager) onto qgit's window, I now get two dialogs in succession: the one you added then, immediately, the one that asks if the patch is to be applied to the workspace or as a commit. That second dialog also has a "Cancel" option, which doubles the functionality of your newly added dialog.

b) in some situations, an option (checkbox) to not ask for confirmation again would be useful for some users. I am aware that adding a persisted confirmation waiving mechanism would add quite a bit of complexity (like saving the user option to settings file and adding a global option in the settings dialog to reset the confirmation waiving).

c) the "rebase" confirmation dialog is a bit verbose and difficult to read. Trimming the displayed SHAs to 8-12 characters would help.

Thanks for your attention.

[eagafonov]

Hey,

when dropping a patch file

I've never used that :) I'll check and updated the patch for this use-case

in some situations, an option (checkbox) to not ask for confirmation again would be useful for some users

Nice idea. I'll try to implement something.

the "rebase" confirmation dialog is a bit verbose and difficult to read

Yep, though I do not notice that anymore, but just click OK. I'll make prettier version of it.

BR, Eugene.

[eagafonov]

Hi!

I've update the patch: fixed double dialog on dropped patch and refactored confirmation dialogs a bit.

I added a dedicated confirmation for push operations with explicit "Force push" button instead of puni check-box.

All commit's SHAs should be are truncated

[eagafonov]

I havn't added "not ask for confirmation again" yet