Remove unused callbackType property from auth_assert nodes - #4684
Merged
ThumulaPerera merged 1 commit intoAug 7, 2026
Merged
Conversation
ThumulaPerera
requested review from
DonOmalVindula and
brionmario
as code owners
August 7, 2026 11:41
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (4)
💤 Files with no reviewable changes (4)
📝 WalkthroughWalkthroughThe change removes the CIBA ChangesCIBA flow configuration
Estimated code review effort: 1 (Trivial) | ~3 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches 💡 1🛠️ Fix failing CI checks 💡
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ThaminduDilshan
approved these changes
Aug 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Purpose
This pull request removes the
callbackTypeproperty with value"urn:openid:params:grant-type:ciba"from allauth_asserttask execution nodes across several configuration and template files. This change simplifies theauth_assertnode definitions and ensures consistency across different environments.Approach
callbackTypeproperty from theauth_asserttask infrontend/apps/console/src/features/flows/data/templates.json.callbackTypeproperty from theauth_asserttask ininstall/openchoreo/thunderid-oc-resourcetype/samples/resource.yaml.callbackTypeproperty from allauth_assertnodes insamples/apps/wayfinder-sample/thunderid-config/app-native/thunderid-config.yaml. [1] [2]callbackTypeproperty from allauth_assertnodes insamples/apps/wayfinder-sample/thunderid-config/redirect/thunderid-config.yaml. [1] [2]Related Issues
Related PRs
Checklist
breaking changelabel added.Security checks
Summary by CodeRabbit