Skip to content

Remove unused callbackType property from auth_assert nodes - #4684

Merged
ThumulaPerera merged 1 commit into
thunder-id:mainfrom
ThumulaPerera:remove-unused-node-property
Aug 7, 2026
Merged

Remove unused callbackType property from auth_assert nodes#4684
ThumulaPerera merged 1 commit into
thunder-id:mainfrom
ThumulaPerera:remove-unused-node-property

Conversation

@ThumulaPerera

@ThumulaPerera ThumulaPerera commented Aug 7, 2026

Copy link
Copy Markdown
Member

Purpose

This pull request removes the callbackType property with value "urn:openid:params:grant-type:ciba" from all auth_assert task execution nodes across several configuration and template files. This change simplifies the auth_assert node definitions and ensures consistency across different environments.

Approach

  • Removed the callbackType property from the auth_assert task in frontend/apps/console/src/features/flows/data/templates.json.
  • Removed the callbackType property from the auth_assert task in install/openchoreo/thunderid-oc-resourcetype/samples/resource.yaml.
  • Removed the callbackType property from all auth_assert nodes in samples/apps/wayfinder-sample/thunderid-config/app-native/thunderid-config.yaml. [1] [2]
  • Removed the callbackType property from all auth_assert nodes in samples/apps/wayfinder-sample/thunderid-config/redirect/thunderid-config.yaml. [1] [2]

Related Issues

  • N/A

Related PRs

Checklist

  • Followed the contribution guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
    • Ran Vale and fixed all errors and warnings
  • Tests provided. (Add links if there are any)
    • Unit Tests
    • Integration Tests
  • Breaking changes. (Fill if applicable)
    • Breaking changes section filled.
    • breaking change label added.

Security checks

  • Followed secure coding standards in WSO2 Secure Coding Guidelines
  • Confirmed that this PR doesn't commit any keys, passwords, tokens, usernames, or other secrets.

Summary by CodeRabbit

  • Bug Fixes
    • Updated CIBA email and SMS notification flows to remove an obsolete callback type setting.
    • Standardized authentication assertion behavior across the default flow templates and sample configurations.
    • Existing authentication and success-handling steps remain unchanged.

@coderabbitai

coderabbitai Bot commented Aug 7, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: b004bc7f-4281-4efa-b4df-2736ddae9d98

📥 Commits

Reviewing files that changed from the base of the PR and between 057f70c and 2d8679d.

📒 Files selected for processing (4)
  • frontend/apps/console/src/features/flows/data/templates.json
  • install/openchoreo/thunderid-oc-resourcetype/samples/resource.yaml
  • samples/apps/wayfinder-sample/thunderid-config/app-native/thunderid-config.yaml
  • samples/apps/wayfinder-sample/thunderid-config/redirect/thunderid-config.yaml
💤 Files with no reviewable changes (4)
  • frontend/apps/console/src/features/flows/data/templates.json
  • install/openchoreo/thunderid-oc-resourcetype/samples/resource.yaml
  • samples/apps/wayfinder-sample/thunderid-config/redirect/thunderid-config.yaml
  • samples/apps/wayfinder-sample/thunderid-config/app-native/thunderid-config.yaml

📝 Walkthrough

Walkthrough

The change removes the CIBA callbackType property from auth_assert tasks in the console template and sample email and SMS notification flow configurations.

Changes

CIBA flow configuration

Layer / File(s) Summary
Remove auth_assert callback type
frontend/apps/console/src/features/flows/data/templates.json, install/openchoreo/thunderid-oc-resourcetype/samples/resource.yaml, samples/apps/wayfinder-sample/thunderid-config/...
The CIBA email and SMS notification flows no longer set properties.callbackType on auth_assert tasks. Other flow steps remain unchanged.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

Suggested reviewers: donomalvindula, brionmario

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the removal of the unused callbackType property from auth_assert nodes.
Description check ✅ Passed The description explains the purpose and approach, lists affected files, and includes related items, checklist, and security sections.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
🛠️ Fix failing CI checks 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@ThumulaPerera ThumulaPerera added skip-changelog Skip generating changelog for a particular PR trigger-pr-builder Add when the PR is ready for CI; starts the PR Builder for this and all later pushes labels Aug 7, 2026
@ThaminduDilshan ThaminduDilshan added Type/Bug and removed skip-changelog Skip generating changelog for a particular PR labels Aug 7, 2026
@ThumulaPerera
ThumulaPerera added this pull request to the merge queue Aug 7, 2026
Merged via the queue into thunder-id:main with commit 837be0c Aug 7, 2026
68 of 84 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

trigger-pr-builder Add when the PR is ready for CI; starts the PR Builder for this and all later pushes Type/Bug

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants