Consolidate Apple notification implementations#543
Open
Elvin-Thudugala-2degrees wants to merge 1 commit into
Open
Conversation
Replace duplicated iOS and Mac Catalyst implementations with shared Apple sources and centralized platform guards. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
|
Nice one! Thanks!! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Consolidates the duplicated iOS and Mac Catalyst notification implementations into shared Apple sources. It centralizes platform and version guards, preserves the existing public API, and ensures Mac Catalyst uses its own runtime checks.
Why are we doing this? Any context or related work?
The two platform implementations were nearly identical, which doubled the maintenance surface and made platform behavior easy to drift. Sharing the implementation removes roughly 900 net lines while keeping platform-specific differences explicit and warning-free.