Small improvements - #201
Open
Rifdhan wants to merge 1 commit into
Open
Conversation
Rifdhan
commented
Aug 13, 2026
Rifdhan
commented
Collaborator
- Update iframe_url description to mention stripping tsmcp flag if presenting links to the user
- Improve error logging with more details
- Add additional Honeycomb metrics tracking
- Update iframe_url description to mention stripping tsmcp flag if presenting links to the user - Improve error logging with more details - Add additional Honeycomb metrics tracking
Deploying with
|
| Status | Name | Latest Commit | Updated (UTC) |
|---|---|---|---|
| ✅ Deployment successful! View logs |
rifdhan-test-app | 26be378 | Aug 13 2026, 11:33 PM |
mouryab
reviewed
Aug 14, 2026
| { | ||
| ...GET_SESSION_UPDATES_SHARED_TOOL_DEFINITION, | ||
| description: GET_SESSION_UPDATES_RAW_DESCRIPTION, | ||
| description: `${GET_SESSION_UPDATES_SHARED_TOOL_DEFINITION.description} The \`session_updates\` are returned in their raw and unmodified form. The shape of each update may be different, and there are no guarantees on what fields may be present. For \`answer\` updates, the \`answer_id\` field will not be present (for use with the \`create_liveboard\` tool). You can reconstruct this field using the following formula: \`answer_id = JSON.stringify({ session_id: answer_update.metadata.session_id, gen_no: answer_update.metadata.gen_no })\`.`, |
There was a problem hiding this comment.
create_dashboard instead of create_liveboard
mouryab
reviewed
Aug 14, 2026
| const span = trace.getSpan(context.active()); | ||
| span?.setAttribute( | ||
| "enable_raw_session_updates", | ||
| this.ctx.props.enableRawSessionUpdates ?? "(not passed)", |
There was a problem hiding this comment.
String(this.ctx.props.enableRawSessionUpdates ?? "(not passed)").
mouryab
reviewed
Aug 14, 2026
| const span = this.initSpanWithCommonAttributes(); | ||
| span?.setAttribute( | ||
| "enable_raw_session_updates", | ||
| this.ctx.props.enableRawSessionUpdates ?? "(not passed)", |
There was a problem hiding this comment.
String(this.ctx.props.enableRawSessionUpdates ?? "(not passed)")
mouryab
reviewed
Aug 14, 2026
| "Error event in event stream, error code", | ||
| item.error_code, | ||
| ); | ||
| console.error("Error event in event stream:", item); |
There was a problem hiding this comment.
event item might be big json. Not sure if we should log the whoe thing.
mouryab
reviewed
Aug 14, 2026
| { | ||
| ...GET_SESSION_UPDATES_SHARED_TOOL_DEFINITION, | ||
| description: GET_SESSION_UPDATES_RAW_DESCRIPTION, | ||
| description: `${GET_SESSION_UPDATES_SHARED_TOOL_DEFINITION.description} The \`session_updates\` are returned in their raw and unmodified form. The shape of each update may be different, and there are no guarantees on what fields may be present. For \`answer\` updates, the \`answer_id\` field will not be present (for use with the \`create_liveboard\` tool). You can reconstruct this field using the following formula: \`answer_id = JSON.stringify({ session_id: answer_update.metadata.session_id, gen_no: answer_update.metadata.gen_no })\`.`, |
There was a problem hiding this comment.
For answer updates, shouldn't we have answer_id
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.