Add support for test arguments to remote test commands - #3552
Merged
toastwaffle merged 5 commits intoJul 23, 2026
Conversation
This adds support for `BuildState.TestArgs` to remote builds. This includes support for `TestFields.ArgsPlaceholder`
chris-franklin
force-pushed
the
remote-test-args
branch
from
July 22, 2026 17:33
27900d7 to
95fb592
Compare
chris-franklin
marked this pull request as ready for review
July 22, 2026 17:38
toastwaffle
requested changes
Jul 23, 2026
| shouldSandbox := target.Sandbox | ||
| if state.NeedTests { | ||
| cmd = target.GetTestCommand(state) | ||
| cmd, _ = core.TestCommand(state, target) |
Contributor
There was a problem hiding this comment.
please at least log this error
ditto below
Contributor
Author
There was a problem hiding this comment.
I went for logging here, but in the other places I relay it upwards, and it does seem like that will eventually be logged.
… from `TestCommand`
chris-franklin
commented
Jul 23, 2026
toastwaffle
approved these changes
Jul 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for
BuildState.TestArgsto remote builds. This includes support forTestFields.ArgsPlaceholder.It does this by introducing a central function for doing it, which wraps the call to
ReplaceTestSequences.It also updates
shell_output.goso that the correct command is shown when using--shell.The remote test build that was previously failing due to the presence of the placeholder passed when using this change, and using
--shellalso showed the correct command.