Out of range bugfix#167
Open
olive-tree-branch wants to merge 1 commit into
Open
Conversation
Fixed the std::out_of_range exception that was happening in the unit tests for the functions: - bin_to_dec - oct_to_dec
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the std::out_of_range exception that was happening in the unit tests for the functions:
bin_to_decoct_to_decThis problem that was causing the exception to be thrown was the call to
std::stoiin the functions above which were returning anunsigned int. This was resolved by changingstd::stoitostatic_cast<unsigned int>(std::stoul(...))to have the correct return type and avoid a-Werror-conversionflag.Type of change
How Has This Been Tested?
Both sktest and skunit_tests were ran and no exceptions were thrown and no tests were failed for the two functions that were changed.
Testing Checklist
Checklist