chore(deps): update dependency azure.resourcemanager.appservice to 1.5.0 - #3605
chore(deps): update dependency azure.resourcemanager.appservice to 1.5.0#3605thomhurst wants to merge 2 commits into
Conversation
Code reviewNo issues found. This is an automated Renovate dependency-update PR bumping |
Add the replacement Azure Domain Registration package and move domain provisioning off the removed App Service API.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7afb758bff
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| using AppServiceDomainData = Azure.ResourceManager.DomainRegistration.AppServiceDomainData; | ||
| using AppServiceDomainResource = Azure.ResourceManager.DomainRegistration.AppServiceDomainResource; |
There was a problem hiding this comment.
Preserve the existing AppServiceDomain type identity
When consumers use AzureComputeProvisioner.AppServiceDomain, these aliases change its public parameter and return types from Azure.ResourceManager.AppService types to distinct Azure.ResourceManager.DomainRegistration types. Existing source callers can no longer pass their prior AppServiceDomainData, and already-compiled callers cannot resolve the old method signature; the repository's AzureComputeProvisionerContractTests.AppServiceDomain_Preserves_AppService_Sdk_Contract explicitly asserts the previous type identities. Migrate the implementation without silently changing this public contract, or handle the change as an intentional breaking release.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Confirmed. Azure.ResourceManager.AppService 1.5.0 removes AppServiceDomainData, AppServiceDomainResource, and the rest of the domain API surface (166 breaking API changes). The replacement Azure.ResourceManager.DomainRegistration 1.0.0-beta.1 types have distinct assembly/type identities, so this upgrade cannot preserve the existing source or ABI contract. This dependency update is therefore not safe for the current release line.
|
Closing this Renovate update because Azure.ResourceManager.AppService 1.5.0 removes the public domain types exposed by ModularPipelines.Azure. Migrating to the beta DomainRegistration package would be an intentional breaking API/ABI change and must be handled in a separately planned major-version change, not a dependency-only PR. |
Pull request was closed
Renovate Ignore NotificationBecause you closed this PR without merging, Renovate will ignore this update ( If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR. |
This PR contains the following updates:
1.4.1→1.5.0Release Notes
Azure/azure-sdk-for-net (Azure.ResourceManager.AppService)
v1.5.0Compare Source
1.5.0 (2026-06-02)
Features Added
Bugs Fixed
AppServiceApiDefinitionInfo.Uriis not a valid URI.FunctionAppStorage.Valueis not a valid URI.Other Changes
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Enabled.
♻ Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate.