Skip to content

chore(deps): update dependency azure.resourcemanager.appservice to 1.5.0 - #3605

Closed
thomhurst wants to merge 2 commits into
mainfrom
renovate/azure-azure-sdk-for-net-monorepo
Closed

chore(deps): update dependency azure.resourcemanager.appservice to 1.5.0#3605
thomhurst wants to merge 2 commits into
mainfrom
renovate/azure-azure-sdk-for-net-monorepo

Conversation

@thomhurst

Copy link
Copy Markdown
Owner

This PR contains the following updates:

Package Change Age Confidence
Azure.ResourceManager.AppService (source) 1.4.11.5.0 age confidence

Release Notes

Azure/azure-sdk-for-net (Azure.ResourceManager.AppService)

v1.5.0

Compare Source

1.5.0 (2026-06-02)

Features Added
  • Upgraded api-version to 2025-05-01.
  • Separated CertificateRegistration and DomainRegistration from App Service.
Bugs Fixed
  • Fix deserialization when AppServiceApiDefinitionInfo.Uri is not a valid URI.
  • Fix deserialization when FunctionAppStorage.Value is not a valid URI.
Other Changes
  • Upgraded dependent Azure.Core to 1.57.0.
  • Upgraded dependent Azure.ResourceManager to 1.14.0.

Configuration

📅 Schedule: (UTC)

  • Branch creation
    • At any time (no schedule defined)
  • Automerge
    • At any time (no schedule defined)

🚦 Automerge: Enabled.

Rebasing: Whenever PR is behind base branch, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR has been generated by Mend Renovate.

@thomhurst thomhurst added dependencies Pull requests that update a dependency file MINOR renovate-bot labels Aug 2, 2026
@thomhurst
thomhurst enabled auto-merge (squash) August 2, 2026 08:20
@claude

claude Bot commented Aug 2, 2026

Copy link
Copy Markdown

Code review

No issues found. This is an automated Renovate dependency-update PR bumping Azure.ResourceManager.AppService from 1.4.1 to 1.5.0 in Directory.Packages.props — a single-line version change with no other code affected. Automerge is enabled and nothing here requires manual code review.

Add the replacement Azure Domain Registration package and move domain provisioning off the removed App Service API.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 7afb758bff

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +5 to +6
using AppServiceDomainData = Azure.ResourceManager.DomainRegistration.AppServiceDomainData;
using AppServiceDomainResource = Azure.ResourceManager.DomainRegistration.AppServiceDomainResource;

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Preserve the existing AppServiceDomain type identity

When consumers use AzureComputeProvisioner.AppServiceDomain, these aliases change its public parameter and return types from Azure.ResourceManager.AppService types to distinct Azure.ResourceManager.DomainRegistration types. Existing source callers can no longer pass their prior AppServiceDomainData, and already-compiled callers cannot resolve the old method signature; the repository's AzureComputeProvisionerContractTests.AppServiceDomain_Preserves_AppService_Sdk_Contract explicitly asserts the previous type identities. Migrate the implementation without silently changing this public contract, or handle the change as an intentional breaking release.

Useful? React with 👍 / 👎.

Copy link
Copy Markdown
Owner Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Confirmed. Azure.ResourceManager.AppService 1.5.0 removes AppServiceDomainData, AppServiceDomainResource, and the rest of the domain API surface (166 breaking API changes). The replacement Azure.ResourceManager.DomainRegistration 1.0.0-beta.1 types have distinct assembly/type identities, so this upgrade cannot preserve the existing source or ABI contract. This dependency update is therefore not safe for the current release line.

@thomhurst

Copy link
Copy Markdown
Owner Author

Closing this Renovate update because Azure.ResourceManager.AppService 1.5.0 removes the public domain types exposed by ModularPipelines.Azure. Migrating to the beta DomainRegistration package would be an intentional breaking API/ABI change and must be handled in a separately planned major-version change, not a dependency-only PR.

@thomhurst thomhurst closed this Aug 2, 2026
auto-merge was automatically disabled August 2, 2026 08:55

Pull request was closed

@thomhurst

Copy link
Copy Markdown
Owner Author

Renovate Ignore Notification

Because you closed this PR without merging, Renovate will ignore this update (1.5.0). You will get a PR once a newer version is released. To ignore this dependency forever, add it to the ignoreDeps array of your Renovate config.

If you accidentally closed this PR, or if you changed your mind: rename this PR to get a fresh replacement PR.

@thomhurst
thomhurst deleted the renovate/azure-azure-sdk-for-net-monorepo branch August 2, 2026 09:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

dependencies Pull requests that update a dependency file MINOR renovate-bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants