Skip to content

chore: retire the pr-review mirror; the contract is single-sourced in orbit-ui-mobile - #469

Merged
thomasluizon merged 1 commit into
mainfrom
fix/retire-the-pr-review-mirror
Aug 10, 2026
Merged

chore: retire the pr-review mirror; the contract is single-sourced in orbit-ui-mobile#469
thomasluizon merged 1 commit into
mainfrom
fix/retire-the-pr-review-mirror

Conversation

@thomasluizon

Copy link
Copy Markdown
Owner

Half of orbit-ui-mobile#708. The duplicated pr-review contract is what required the parity gate that stalled every review twice; with the ui side single-sourcing the contract and materializing the rubric into each review order, this copy has nothing left to protect.

  • .claude/skills/pr-review/SKILL.md becomes a pointer for interactive use from this checkout (the canonical contract, environment rules, and rubric live in orbit-ui-mobile).
  • .claude/skills/pr-review/rubric.md deleted.
  • .claude/skills/_shared/verification-protocol.md deleted: its own header says it serves only the api pr-review copy, and nothing in this repository loads it.
  • AGENTS.md drops the stale Linear wording (the prompt is a GitHub ticket body).

Merge orbit-ui-mobile#708 first or together with this; the old parity gate lives in the ui tools, so this PR cannot break a review on its own. Supersedes #468, which re-mirrored the old copy.

🤖 Generated with Claude Code

… orbit-ui-mobile

The mirrored SKILL.md and rubric.md existed so a reviewer session in this
checkout could resolve the skill, and their drift gate halted every review
in both repositories twice (CRLF materialization 2026-08-08; a mirror taken
six minutes before the canonical side moved, 2026-08-09). Orchestrated
reviews never read these files: the review order carries a rubric snapshot
materialized from orbit-ui-mobile origin/main. The skill becomes a pointer
for interactive use, the rubric copy and the api-only
verification-protocol mirror are deleted, and AGENTS.md drops its stale
Linear wording.

Companion: orbit-ui-mobile#708.

Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: a0d3fb3af0

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment on lines +17 to +18
1. `C:\Users\thoma\Documents\Programming\Projects\orbit-ui-mobile\.claude\skills\pr-review\SKILL.md`
2. `C:\Users\thoma\Documents\Programming\Projects\orbit-ui-mobile\.claude\skills\pr-review\rubric.md`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Resolve the canonical skill without a workstation-specific path

In any interactive review outside Thomas's Windows checkout, including Linux/cloud clones such as /workspace/orbit-api, these literal C:\Users\thoma\... files do not exist. Since this commit also deletes the local contract and rubric, /pr-review cannot load its instructions and the repository's required local review path is blocked. Resolve the sibling checkout dynamically, allow a configured canonical path, or provide a fetch/materialization fallback.

Useful? React with 👍 / 👎.

Comment on lines +21 to +22
reads this file at all: `tools/launch-worker.mjs --review` hands the reviewer a complete review
order whose rubric snapshot is materialized from orbit-ui-mobile `origin/main`.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P1 Badge Verify the launcher contract before deleting the fallback

For orchestrated API reviews, deleting the only local contract now depends on the external tools/launch-worker.mjs --review flag producing a complete review order and materializing the UI rubric, but the supplied change provides only that assertion, not a real redacted invocation or installed-source evidence for the consumed behavior. If the flag or output differs, reviewers silently lose the contract after these deletions; include reproducible evidence for the complete consumed result or retain a path that does not depend on this unconfirmed interface.

AGENTS.md reference: AGENTS.md:L104-L108

Useful? React with 👍 / 👎.

@sonarqubecloud

sonarqubecloud Bot commented Aug 9, 2026

Copy link
Copy Markdown

@thomasluizon
thomasluizon merged commit 54801f4 into main Aug 10, 2026
22 checks passed
@thomasluizon
thomasluizon deleted the fix/retire-the-pr-review-mirror branch August 10, 2026 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant