Filter out unavailable issue labels from generated issues - #107
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Please include a summary of the change and which issue is fixed. Also include relevant motivation and context.
I implemented a new function,
filterToAvailableLabels, to ensure that only labels actually present in the repository are applied to generated issues. This function is integrated into theGenerateFromDiff,GenerateFromDescription, andGenerateFromPRmethods of theIssueGeneratorService.The motivation for this change is to prevent the application of non-existent labels. Issue templates or AI-generated content might suggest labels that have not been created in the GitHub repository, leading to inconsistencies or errors when attempting to apply them.
Fixes #
Type of Change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce.
I added a new unit test case in
issue_generator_service_test.goto specifically verify thatfilterToAvailableLabelscorrectly drops labels that do not exist in the mock repository's available labels list.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass