Add retry and cache invalidation for Gemini AI services - #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
I implemented a retry mechanism for Gemini AI service calls (commit summarization, issue content generation, PR summarization, and release notes generation). This change addresses scenarios where the AI service returns an empty or malformed response, such as truncated JSON, which can occur due to network issues or incomplete generation.
To support this, I added an
InvalidateCachemethod to theCostAwareWrapperandcache.go. This method allows the system to remove a problematic cached response immediately upon detecting an invalid AI output, ensuring that subsequent retries fetch a fresh response instead of repeatedly serving the bad cached data until its TTL expires. Each AI generation function now attempts to generate content up to two times, invalidating the cache if the first attempt yields an unusable response.Fixes #
Type of Change
How Has This Been Tested?
I added unit tests in
internal/ai/gemini/release_generator_test.goto verify the retry logic. These tests cover cases where the AI initially returns truncated JSON but succeeds on a retry, and where it consistently returns malformed data, leading to the retry mechanism giving up.Checklist
Test Plan & Evidence
Suggested Manual Verification
go test ./...and ensure all tests pass