Skip to content

docs: add resume safety checks to handoffs - #2

Open
caioribeiroclw-pixel wants to merge 2 commits into
thepushkarp:mainfrom
caioribeiroclw-pixel:caio/resume-safety-check
Open

docs: add resume safety checks to handoffs#2
caioribeiroclw-pixel wants to merge 2 commits into
thepushkarp:mainfrom
caioribeiroclw-pixel:caio/resume-safety-check

Conversation

@caioribeiroclw-pixel

Copy link
Copy Markdown

Summary

  • add a Resume Safety Check section to generated handoffs
  • teach /handoff:resume --auto to stop instead of acting when the handoff marks auto-resume unsafe or stale
  • document evidence-to-verify, staleness risks, and unsafe auto-resume conditions in the README example

Why

Handoff summaries are useful, but the next session can over-trust stale or incomplete context. A small safety section makes the boundary explicit: what should be verified before continuing, what may have changed, and when review mode is safer than auto-resume.

Checks

  • bash -n plugins/handoff/scripts/*.sh
  • git diff --check

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces a new "Resume Safety Check" section to the handoff documentation and processes. This section captures evidence to verify, staleness risks, and conditions under which auto-resuming is unsafe. The resume command instructions are updated to check these safety conditions and prompt the user if auto-resume is unsafe or if evidence is missing. The review comments suggest further improving this safety mechanism by explicitly handling unfilled placeholders (such as TODO or bracketed placeholders) as unsafe or stale, both in interactive and auto-resume modes.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

Comment thread plugins/handoff/commands/resume.md Outdated
- Any blockers
- Next steps listed
- Resume safety checks, including evidence to verify and unsafe-to-auto-resume conditions
- If the handoff says auto-resume is unsafe, or if required evidence is missing/stale, say that clearly before offering next actions.

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

If the handoff contains unfilled placeholders (such as TODO or [...]), it should be treated as unsafe or stale. We should explicitly instruct the model to check for these unfilled placeholders and warn the user before offering next actions.

Suggested change
- If the handoff says auto-resume is unsafe, or if required evidence is missing/stale, say that clearly before offering next actions.
- If the handoff says auto-resume is unsafe, required evidence is missing/stale, or contains unfilled placeholders (such as TODO or bracketed placeholders), say that clearly before offering next actions.

Comment thread plugins/handoff/commands/resume.md Outdated
Comment on lines +41 to +42
- Check the "Resume Safety Check" section before acting
- If the handoff says auto-resume is unsafe, or required evidence is missing/stale, stop and ask the user how to proceed instead of acting

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

medium

In --auto mode, if the handoff has unfilled placeholders, it is highly unsafe to auto-resume because the safety checks were never actually written. Instructing the model to stop and ask the user how to proceed in this case prevents unintended actions.

Suggested change
- Check the "Resume Safety Check" section before acting
- If the handoff says auto-resume is unsafe, or required evidence is missing/stale, stop and ask the user how to proceed instead of acting
- Check the "Resume Safety Check" section before acting
- If the handoff says auto-resume is unsafe, required evidence is missing/stale, or the section contains unfilled placeholders (such as TODO or bracketed placeholders), stop and ask the user how to proceed instead of acting

@caioribeiroclw-pixel

caioribeiroclw-pixel commented Jun 4, 2026

Copy link
Copy Markdown
Author

Addressed the Gemini review's placeholder concern in the PR branch.

Changes:

  • /handoff:resume now treats unfilled TODO / bracketed placeholders as missing evidence in both review mode and --auto mode.
  • pre-compaction auto-save now explicitly marks auto-resume unsafe while TODO/bracketed placeholders remain.
  • /handoff:create and README now call out that placeholders make a handoff non-resumable.
  • bumped plugin version to 0.2.1 so plugin-content updates are visible to existing users.

Validation:

  • git diff --check
  • bash -n plugins/handoff/scripts/*.sh
  • python3 -m json.tool plugins/handoff/.claude-plugin/plugin.json

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant