docs: add resume safety checks to handoffs - #2
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces a new "Resume Safety Check" section to the handoff documentation and processes. This section captures evidence to verify, staleness risks, and conditions under which auto-resuming is unsafe. The resume command instructions are updated to check these safety conditions and prompt the user if auto-resume is unsafe or if evidence is missing. The review comments suggest further improving this safety mechanism by explicitly handling unfilled placeholders (such as TODO or bracketed placeholders) as unsafe or stale, both in interactive and auto-resume modes.
Important
The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.
| - Any blockers | ||
| - Next steps listed | ||
| - Resume safety checks, including evidence to verify and unsafe-to-auto-resume conditions | ||
| - If the handoff says auto-resume is unsafe, or if required evidence is missing/stale, say that clearly before offering next actions. |
There was a problem hiding this comment.
If the handoff contains unfilled placeholders (such as TODO or [...]), it should be treated as unsafe or stale. We should explicitly instruct the model to check for these unfilled placeholders and warn the user before offering next actions.
| - If the handoff says auto-resume is unsafe, or if required evidence is missing/stale, say that clearly before offering next actions. | |
| - If the handoff says auto-resume is unsafe, required evidence is missing/stale, or contains unfilled placeholders (such as TODO or bracketed placeholders), say that clearly before offering next actions. |
| - Check the "Resume Safety Check" section before acting | ||
| - If the handoff says auto-resume is unsafe, or required evidence is missing/stale, stop and ask the user how to proceed instead of acting |
There was a problem hiding this comment.
In --auto mode, if the handoff has unfilled placeholders, it is highly unsafe to auto-resume because the safety checks were never actually written. Instructing the model to stop and ask the user how to proceed in this case prevents unintended actions.
| - Check the "Resume Safety Check" section before acting | |
| - If the handoff says auto-resume is unsafe, or required evidence is missing/stale, stop and ask the user how to proceed instead of acting | |
| - Check the "Resume Safety Check" section before acting | |
| - If the handoff says auto-resume is unsafe, required evidence is missing/stale, or the section contains unfilled placeholders (such as TODO or bracketed placeholders), stop and ask the user how to proceed instead of acting |
|
Addressed the Gemini review's placeholder concern in the PR branch. Changes:
Validation:
|
Summary
Resume Safety Checksection to generated handoffs/handoff:resume --autoto stop instead of acting when the handoff marks auto-resume unsafe or staleWhy
Handoff summaries are useful, but the next session can over-trust stale or incomplete context. A small safety section makes the boundary explicit: what should be verified before continuing, what may have changed, and when review mode is safer than auto-resume.
Checks
bash -n plugins/handoff/scripts/*.shgit diff --check