Sync with minimal repo setup guide in .github - #343
Merged
Conversation
Contributor
Reviewer's Guide by SourceryThis pull request updates the .pre-commit-config.yaml file to align with the minimal repo setup guide. Key changes include setting a max file size limit of 100KB for the 'check-added-large-files' hook, reordering the 'check-yaml' hook, excluding binary files from the 'remove-crlf' hook, and updating the 'ruff-pre-commit' hook version from v0.4.8 to v0.4.9. File-Level Changes
Tips
|
|
Here's the code health analysis summary for commits Analysis Summary
|
Contributor
There was a problem hiding this comment.
Hey @tovrstra - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 2 issues found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟡 Documentation: 2 issues found
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>
Member
Author
|
Thanks for reviewing. Merging... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This brings the IOData repo in line with the instructions in theochem/.github#7
See #313 and theochem/.github#5 for more background.
I've added a relatively conservative max file size, but we can still make exceptions if needed. IOData does not use Git LFS, which I'm inclined to keep that way. My experiences so far with Git LFS have not been great.
Summary by Sourcery
This pull request updates the .pre-commit-config.yaml file to align with the minimal repository setup guide, including setting a conservative max file size limit and excluding binary files from CRLF removal.