fix(deps): raise lodash override above GHSA-r5fr-rjxr-66jc - #198
Merged
Conversation
The pin sat at exactly 4.17.23, which is the patched version for the older advisory (<=4.17.22) but is itself inside the range of the newer one: GHSA-r5fr-rjxr-66jc covers >=4.0.0 <=4.17.23, first patched in 4.18.0. Dependency Review fails every PR whose diff touches the lockfile overrides block because of it — #187 is the current example. lodash is not in the dependency graph at all right now (zero entries in the lockfile), so this floor is purely defensive: it costs nothing today and covers the case where something pulls lodash back in. Checked the other eleven overrides against the GitHub Advisory DB while I was here; none of them are below their patched version. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
github-actions Bot
pushed a commit
that referenced
this pull request
Aug 24, 2026
## [1.0.3](v1.0.2...v1.0.3) (2026-08-24) ### Bug Fixes * **deps:** raise lodash override above GHSA-r5fr-rjxr-66jc ([#198](#198)) ([ade9307](ade9307)), closes [#187](#187)
|
🎉 This PR is included in version 1.0.3 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
10 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Dependency Reviewis failing on #187 — and will fail on every rebased dependabot PR — with:The pin was one advisory generation behind.
4.17.23is the patched version for the older advisory (<=4.17.22), but it sits inside the range of the newer one —>=4.0.0 <=4.17.23, first patched in 4.18.0. Exactly the stale-exact-pin pattern #184 cleaned up forws,fast-uriandbrace-expansion; this one I carried over verbatim rather than raising, and it turned out to be stale too.Worth knowing
lodash is not in the dependency graph — zero package entries in
pnpm-lock.yaml, nothing innode_modules. What Dependency Review reports is the override declaration itself, read out of the lockfile'soverrides:block. So this floor is purely defensive: it costs nothing today and covers the case where something pulls lodash back in transitively. If you would rather not carry dead pins, deleting the line entirely works just as well — say the word and I will swap the approach.I checked the other eleven overrides against the GitHub Advisory DB while I was in here. None are below their patched version:
hono >=4.12.25,brace-expansion >=5.0.9,fast-uri >=3.1.5,ws >=8.21.0effect 3.20.0,fast-jwt 6.2.4,@hono/node-server 1.19.13picomatch ^4.0.4,yaml ^2.8.3,fast-xml-parser ^5.5.7,vite 8.0.16Type of Change
Checklist
feature/,fix/,chore/,docs/)Verified on top of current
main(which now carries the ioredis 6.0.0 major from #197):pnpm build,pnpm lint,pnpm test:unit597/597 all clean.Two-line diff — the override string in
pnpm-workspace.yamland its mirror in the lockfile.🤖 Generated with Claude Code