fix: SW-2441 Prevent data table pagination overflow - #210
Open
vmujakovic-ts wants to merge 1 commit into
Open
Conversation
vmujakovic-ts
temporarily deployed
to
artifactory-prod
September 9, 2026 18:31 — with
GitHub Actions
Inactive
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
There was a problem hiding this comment.
✅ No issues found
About Unblocked
Unblocked has been set up to automatically review your team's pull requests to identify genuine bugs and issues.
📖 Documentation — Learn more in our docs.
💬 Ask questions — Mention @unblocked to request a review or summary, or ask follow-up questions.
👍 Give feedback — React to comments with 👍 or 👎 to help us improve.
⚙️ Customize — Adjust settings in your preferences.
vmujakovic-ts
force-pushed
the
SW-2441-pagination-fix
branch
from
September 9, 2026 18:39
c3d19b9 to
b5702e6
Compare
vmujakovic-ts
temporarily deployed
to
artifactory-prod
September 9, 2026 18:39 — with
GitHub Actions
Inactive
Collapse distant page numbers into a bounded seven-item window with ellipses, and let the pagination metadata and navigation controls wrap in narrow containers. Cover all three windowing branches (near-start, middle, near-end) plus the unwindowed path, keeping the component at 100% statement coverage. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
vmujakovic-ts
force-pushed
the
SW-2441-pagination-fix
branch
from
September 9, 2026 18:52
b5702e6 to
2f0062e
Compare
vmujakovic-ts
temporarily deployed
to
artifactory-prod
September 9, 2026 18:52 — with
GitHub Actions
Inactive
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||
owilliams-tetrascience
approved these changes
Sep 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Jira
SW-2441
Summary
DataTablePaginationrendered one button per page in a single horizontalrow. On tables with many pages the control grew past the available table
width and ran off the page, pushing the next/previous buttons out of reach
and making navigation difficult or inaccessible.
The page list is now capped at a bounded seven-item window that always
keeps the first page, the last page, and the pages adjacent to the current
one reachable. Skipped ranges collapse into non-interactive ellipses:
1 2 3 4 5 … 201 … 9 10 11 … 201 … 16 17 18 19 20Tables with seven or fewer pages are unchanged and still render every page
number. As a second line of defense for narrow containers, the pagination
row and its two groups may now wrap (
flex-wrap) instead of overflowing.Previous/next controls, page-size selection, and the
aria-label/aria-currentsemantics on each page button are unchanged. The ellipsesare
aria-hiddenso they add no screen-reader noise.Type of Change
Checklist
yarn lintpassesyarn buildpassesyarn test:allpassesdata-tablestories cover the unchanged ≤ 7-page pathTesting
Added regression coverage in
data-table.test.tsxfor a 20-page table,exercising every branch of the new windowing helper:
Results:
yarn lint— cleanyarn typecheck— cleanyarn build— cleanyarn test— 1014 passed (64 files)yarn test:storybook— 696 passed (111 files)Coverage:
data-table-pagination.tsxis at 100% statement coverage(86/86 -> 104/104), taking the repo total from 96.9054% to 96.9076%.
Zephyr test cases: none added — the new coverage is a Vitest unit test, not
a story play function.
Verification
Screenshots
Behavioral change is the page-number list; described textually above.