Skip to content

Fix #142: repoint find_files KG-scorer fixture at mcp_server - #12

Merged
AlexMikhalev merged 1 commit into
mainfrom
task/142-mcp-find-files-fixture
Sep 1, 2026
Merged

Fix #142: repoint find_files KG-scorer fixture at mcp_server#12
AlexMikhalev merged 1 commit into
mainfrom
task/142-mcp-find-files-fixture

Conversation

@AlexMikhalev

Copy link
Copy Markdown
Contributor

Fixes #142: find_files_with_kg_scorer_boosts_matching_paths previously
built a thesaurus containing the term automata and asserted that a
path under crates/terraphim_automata/ would be boosted to the top
of the results. The terraphim_automata crate does not exist in
this workspace (the package was retired and its responsibilities moved
to terraphim_mcp_server and terraphim_grep), so the assertion
always failed.

This change repoints the fixture at mcp_server (which has a real
crates/terraphim_mcp_server/ directory) and updates the assertion
to look for the matching path segment. The thesaurus still exercises
the KG-scorer boosting path; only the keyword and assertion substring
change.

Local verification: cargo test -p terraphim_mcp_server --test test_find_files reports 5 passed / 0 failed after this change.

Copy link
Copy Markdown
Contributor Author

Summary

This is the smallest of the four deferred PRs. The find_files_with_kg_scorer_boosts_matching_paths test previously pointed its fixture thesaurus at the term automata and asserted that a path under crates/terraphim_automata/ would be boosted to the top of the results. The terraphim_automata crate does not exist in this workspace, so the assertion always failed.

The change repoints the fixture keyword at mcp_server (which has a real crates/terraphim_mcp_server/ directory) and updates the assertion substring to match. Coverage scope is unchanged: the thesaurus still exercises the KG-scorer boosting path; only the keyword and the substring the assertion checks change. The four companion test cases in test_find_files.rs (find_files_no_scorer_returns_results, find_files_invalid_path_returns_error, grep_files_returns_content_matches, grep_files_files_mode_returns_paths) are untouched, and all five tests pass locally.

Confidence Score: 5/5

  • Safe to merge with minimal risk.
  • The PR is a one-file, one-fixture-keyword swap with a correct rationale. Behaviour coverage scope is preserved. No new code paths, no new dependencies, no environmental coupling.
  • No files require special attention.

Important Files Changed

Filename Overview
crates/terraphim_mcp_server/tests/test_find_files.rs Thesaurus keyword swapped from automata to mcp_server; assertion substring updated to match. Coverage scope unchanged. No issues found.

Inline Findings

No P0, P1, or P2 findings.

Last reviewed commit: 88d9ca2 | Reviews (1)

…Refs #142)

find_files_with_kg_scorer_boosts_matching_paths originally built a
thesaurus containing the term 'automata' and asserted that a path
under crates/terraphim_automata/ would be boosted to the top of the
results. The terraphim_automata crate does not exist in this workspace
(crate name was retired when the package was moved into the
terraphim_mcp_server and terraphim_grep crates), so the assertion
always failed.

Repoint the fixture at 'mcp_server' (which has a real
crates/terraphim_mcp_server/ directory) and update the assertion to
look for the matching path segment. The thesaurus still exercises the
KG-scorer boosting path; only the keyword and assertion substring
change.
@AlexMikhalev
AlexMikhalev force-pushed the task/142-mcp-find-files-fixture branch from 88d9ca2 to 2517f68 Compare September 1, 2026 00:19
@AlexMikhalev
AlexMikhalev merged commit b1c8247 into main Sep 1, 2026
1 check failed
@AlexMikhalev
AlexMikhalev deleted the task/142-mcp-find-files-fixture branch September 1, 2026 00:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant