Fix duplicate snipsync IDs shared with hello-world - #502
Open
lennessyy wants to merge 1 commit into
Open
Conversation
The empty and sleep-for-days samples were scaffolded from hello-world and kept its snippet IDs, so typescript-hello-worker and typescript-hello-client were each defined in three files. Snipsync resolves duplicates silently, so a doc referencing typescript-hello-worker got sleep-for-days rather than hello-world. Renames the copies so both IDs are unique to hello-world.
dplyukhin
approved these changes
Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Renames four snipsync markers so
typescript-hello-workerandtypescript-hello-clientare unique tohello-world/.empty/src/worker.tstypescript-hello-workertypescript-empty-workerempty/src/client.tstypescript-hello-clienttypescript-empty-clientsleep-for-days/src/worker.tstypescript-hello-workertypescript-sleep-for-days-workersleep-for-days/src/client.tstypescript-hello-clienttypescript-sleep-for-days-clientComment-only change; no code is touched.
Why
empty/andsleep-for-days/look scaffolded fromhello-world/and kept its snippet IDs, so each of those two IDs was defined in three files. Snipsync resolves duplicates silently rather than erroring, so whichever file it happens to read last wins.This is not hypothetical. A docs page referencing
typescript-hello-workerfor a "Create and run a Worker" section pulled insleep-for-days/src/worker.tsinstead ofhello-world/src/worker.ts, giving the reader a source link to an unrelated sample.typescript-hello-workeris the only one of these currently referenced by the docs, so this change has no effect on any other page.Not fixed here
Three other duplicate IDs exist in this repo. Each is duplicated within a single sample directory, so the intended source is ambiguous and none is referenced by the docs today:
typescript-esm-client—fetch-esm/src/client-local.ts,fetch-esm/src/client-fetch.tstypescript-message-passing-introduction—message-passing/introduction/src/{client,worker}.tstypescript-polling-infrequent—polling/infrequent/src/{workflows,client,worker}.tsHappy to fold those in if you'd prefer one sweep.