Fix syncookies statistics and tests - #63
Open
krizhanovsky wants to merge 18 commits into
Open
Conversation
krizhanovsky
marked this pull request as draft
August 9, 2026 19:13
krizhanovsky
force-pushed
the
ak-470-syncookies-tests
branch
from
August 10, 2026 17:05
ad52be7 to
1c684ba
Compare
consuelo2210
left a comment
consuelo2210
left a comment
Contributor
There was a problem hiding this comment.
I reviewed only C/C++ part and left python part to @symstu-tempesta. I have the only question about expanding statistic:
Could we consider keeping this within the existing XfwTrafficStat abstraction? From an extensibility perspective, it seems preferable to add XFW_SYNCOOKIE_FAILED there and use count_traffic_stat(...), rather than introducing a separate field and a separate code path. This would also make adding future traffic statistics simpler and avoid special cases in Prometheus.
krizhanovsky
force-pushed
the
ak-470-syncookies-tests
branch
from
August 14, 2026 21:38
680109c to
78b9a55
Compare
krizhanovsky
marked this pull request as ready for review
August 16, 2026 19:13
symstu-tempesta
requested changes
Aug 17, 2026
consuelo2210
approved these changes
Aug 17, 2026
consuelo2210
left a comment
consuelo2210
left a comment
Contributor
There was a problem hiding this comment.
LGTM: just make the alignment consistent after the name changes in drop_stats.h.
Also, commit 78b9a55 has an incorrect description: we don't report XDP_DROP stats to Prometheus.
RomanBelozerov
requested changes
Aug 18, 2026
symstu-tempesta
marked this pull request as draft
August 19, 2026 12:58
symstu-tempesta
force-pushed
the
ak-470-syncookies-tests
branch
from
August 19, 2026 18:10
029cfd7 to
6790dda
Compare
symstu-tempesta
marked this pull request as ready for review
August 19, 2026 18:10
symstu-tempesta
self-requested a review
August 19, 2026 18:19
symstu-tempesta
approved these changes
Aug 19, 2026
Previously we configured passive_timer and flood_timer with 0 by default and tcp_syncookies_flood_mode() and tcp_syncookies_passive_mode() used jiffies (1/HZ sec). This leaded to immediate, and worse - scheduler dependent, switch between the modes. Effectively, flood_timer=0 passive_timer=0 in the tests leaded to flacky behavior. Now by default set the timers to 1 second and discourage 0 values in the wiki. Also make the TCPsyncookies Prometheus counters consistent with the kernel statistics and report generated, received and failed syncookies. This makes the testing an future observability easier. Keep the existing statistics split by packet-processing outcome: generated SYN cookies are TX statistics, failed SYN cookies remain DROP incidents, and received SYN cookies are traffic statistics.
Adopt slightly modified patch by Maksym Stukalo from the Escudo project: add Tempesta xFW Prometheus statistics along the currently monitored /proc/net/netstat - we need all the counters to validate the xFW behavior. Change only one test to check the concept - if it's right, then I'll update the rest of the tests accordingly.
Call XFW.metrics() and run_start() to initialize the metrics values after slef-requests. Small cleanup for fetching syncookies values from /proc/net/netstat Original patch also adjusts the values for syncookies_read_kern_stats(), but in the current version we distinguish between the kernel and xFW statistics and analyze both of them.
* Move TCP syncookie failed counter to traffic stats * Separate common and drop statistics Add comments and rename constants in XfwDropStat to distinguish Prometheus statistic (XDP_DROP, XDP_PASS and common traffic) and ClickHouse events (DROP statistics).
symstu-tempesta
force-pushed
the
ak-470-syncookies-tests
branch
from
August 20, 2026 16:47
4c0685c to
4d24a67
Compare
* It's difficult to set exact metric values because of kernel and XFW work specifics * Added comments * Used variables instead of magic numbers * Added check_xfw_stats to shorten the code for comparing XFW metrics and kernel stats
symstu-tempesta
force-pushed
the
ak-470-syncookies-tests
branch
from
August 20, 2026 19:33
4d24a67 to
d3406dd
Compare
Comment on lines
-973
to
-982
| invalid_acks = sum(acknowledged for _, acknowledged in flood_results) | ||
| # failed [lo, hi] in params is a factor of invalid_acks: [1, 1] exact, [0, 1] any up to that. | ||
| failed_lo, failed_hi = expected_xfw["xfw_syncookie_failed_packets"] | ||
| expected = { | ||
| **expected_xfw, | ||
| "xfw_syncookie_failed_packets": [ | ||
| failed_lo * invalid_acks, | ||
| failed_hi * invalid_acks + 1, | ||
| ], | ||
| } |
There was a problem hiding this comment.
This is unnecessary code originally generated by an LLM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
/proc/net/netstatand make SYNcookies easier to monitor and testXfwDropStatto distinguish Prometheus statistic (XDP_DROP,XDP_PASSand common traffic) and ClickHouse events (DROPstatistics)