fix: make Lua SYSLIBS platform-conditional for macOS compatibility - #33
Open
cyclingwithelephants wants to merge 1 commit into
Open
fix: make Lua SYSLIBS platform-conditional for macOS compatibility#33cyclingwithelephants wants to merge 1 commit into
cyclingwithelephants wants to merge 1 commit into
Conversation
The hardcoded -Wl,-E linker flag is GNU ld specific (--export-dynamic) and is rejected by Apple's ld64 with 'ld: unknown option: -E'. This causes the Lua 5.3 build to fail on macOS, which cascades to everything that depends on it (kyua, lutok, atf, doc build, etc). macOS dyld handles dynamic symbol visibility differently and does not need -Wl,-E, so the flag is now passed only on non-Darwin platforms.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #32
Problem
The Lua 5.3 build in
overlay.nixhardcodes-Wl,-E(GNU ld's--export-dynamic), which Apple's ld64 rejects withld: unknown option: -E. This cascades to fail the doc build and anything else that transitively depends on Lua.Fix
Make the flag platform-conditional — macOS dyld handles dynamic symbol visibility differently and doesn't need
-Wl,-E: