Skip to content

STYE: Avoid shadowing symbols from outer scope #136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
arokem merged 1 commit into from
Aug 23, 2026
Merged

STYE: Avoid shadowing symbols from outer scope #136

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions .spin/cmds.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -213,12 +213,12 @@ def lint(fix):
default=False,
help="Open documentation in browser after building",
)
def docs(clean, open_browser):
def docs(_clean, open_browser):
"""Build documentation using Sphinx.

Parameters
----------
clean : bool
_clean : bool
If True, clean build directory before building.
open_browser : bool
If True, open documentation in browser after building.
Expand All @@ -227,7 +227,7 @@ def docs(clean, open_browser):

docs_dir = "docs"

if clean:
if _clean:
click.echo("Cleaning build directory...")
build_dir = os.path.join(docs_dir, "_build")
if os.path.exists(build_dir):
Expand Down
4 changes: 2 additions & 2 deletions trx/cli.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -993,8 +993,8 @@ def info(
typer.echo(f"Size: {_format_size(file_size)}")

with zipfile.ZipFile(str(in_tractogram), "r") as zf:
total_uncompressed = sum(info.file_size for info in zf.infolist())
is_compressed = any(info.compress_type != 0 for info in zf.infolist())
total_uncompressed = sum(_info.file_size for _info in zf.infolist())
is_compressed = any(_info.compress_type != 0 for _info in zf.infolist())
typer.echo(f"Entries: {len(zf.infolist())}")
typer.echo(f"Compressed: {'Yes' if is_compressed else 'No'}")
typer.echo(f"Uncompressed size: {_format_size(total_uncompressed)}")
Expand Down
Loading