CleanGeek - lift the control styles into Themes/Shell.axaml - #8
Merged
Conversation
Same two-file structure as DiskGeek and PDFGeek: Themes/Dark.axaml for the palette, Themes/Shell.axaml for the control styles. The block is byte-identical to the one that was inline in Views/MainWindow.axaml. It is included at *window* scope, exactly where the block sat, so the styles apply to the same controls as before and the StaticResource lookups keep working - a move, not a change of scope.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needs a run on Windows before merging - I cannot test it there, and the whole point is that nothing changes visually.
CleanGeek and DriverGeek were the last two apps keeping their control styles inline in
Views/MainWindow.axaml. DiskGeek and PDFGeek carry aThemes/Dark.axaml+Themes/Shell.axamlpair. This gives CleanGeek the same shape.The style block is moved byte for byte. It is also byte-identical to the one in the matching DriverGeek PR - the two apps had the same seven selectors.
It is included at window scope, exactly where the block sat:
Not app scope, deliberately.
Application.Stylesis built beforeApplication.Resources, so aStaticResourcelookup there cannot see the palette; and app scope would also start applying the bareTextBlockandButton.ghostrules to the shared About window. Keeping it at window scope makes this a move rather than a change of behaviour.Builds clean, and all four screens were rendered headless from the real XAML afterwards - nav highlight, ghost buttons and text colours all identical to before.