Skip to content

Fix deletion of stopped stateful services - #273

Merged
arjunkomath merged 1 commit into
mainfrom
fix/stopped-stateful-service-deletion
Aug 4, 2026
Merged

Fix deletion of stopped stateful services#273
arjunkomath merged 1 commit into
mainfrom
fix/stopped-stateful-service-deletion

Conversation

@arjunkomath

Copy link
Copy Markdown
Member

Summary

  • allow stopped stateful services to create deletion backups from their locked server
  • preserve reuse of completed backups when every volume is covered
  • update deletion confirmation copy for stopped services

Verification

  • npx biome check --write actions/projects.ts lib/inngest/functions/service-deletion-workflow.ts 'app/(dashboard)/dashboard/projects/[slug]/[env]/services/[serviceId]/configuration/page.tsx'
  • ./node_modules/.bin/tsc --noEmit
  • Vitest: 62 files, 426 tests passed
  • git diff --check

Bug

https://app.basecamp.com/5890597/buckets/47439993/todos/10163020201

@github-actions

github-actions Bot commented Aug 4, 2026

Copy link
Copy Markdown

React Doctor found no issues. 🎉

⚠️ Warning: .github/workflows/react-doctor.yml is configured incorrectly. See below to fix.

React Doctor compares against main to report only the issues this pull request introduces. This run couldn't complete that comparison (usually a shallow CI checkout with no merge base), so it listed every issue in the changed files, including ones that already existed on main.

Add fetch-depth: 0 to the actions/checkout step in .github/workflows/react-doctor.yml so the checkout includes the history React Doctor needs:

 jobs:
   react-doctor:
     steps:
       - uses: actions/checkout@v5
+        with:
+          fetch-depth: 0

       - uses: millionco/react-doctor@v2

To silence this warning, set silence-missing-baseline-warning: true on the React Doctor action.

Reviewed by React Doctor for commit b5f4d2f.

@arjunkomath
arjunkomath added this pull request to the merge queue Aug 4, 2026
Merged via the queue into main with commit 37231e6 Aug 4, 2026
8 checks passed
@arjunkomath
arjunkomath deleted the fix/stopped-stateful-service-deletion branch August 4, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants