fix(sandbox): support readonly Windows host mounts - #67
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
The sandbox runner only enabled host directory mount materialization on macOS. Windows already enforces read-only roots through the restricted sandbox token and ACL plan, but it had no safe alias from the sandbox mount namespace to the host directory. Every Windows workspace tool call therefore failed with
MOUNT_PLATFORM_UNSUPPORTED.Validation
cargo check -p ahandd --all-targetscargo test -p ahandd --lib: 430/431; the sole failure is a pre-existing localized Windows OS error-string assertion inconfig::load_tilde_tests::load_returns_err_for_missing_filecargo fmt --checkgit diff --checkClippy was unavailable because the local stable toolchain does not have the component installed.