feat(run-task): Add perfherder profile markers for Git VCS operations#1005
Merged
Conversation
f6a28a7 to
3813172
Compare
While implementing this patch, I learned that Perfherder actually does not process `PERFHERDER_DATA` anymore. However the TaskclusterETL is still processing it (independently of Perfherder). So that's how we're still able to get clone metrics out of robustcheckout. Given that TaskclusterETL is slated to be removed, it's not great to be adding a new feature that depends on it. However this will allow us to get detailed clone metrics for Git in the short term, which will help out with the migration. Longer term, we'll need to figure out an alternative way to profile `run-task` that doesn't rely on TaskclusterETL.
bhearsum
approved these changes
Jul 14, 2026
jcristau
reviewed
Jul 15, 2026
jcristau
left a comment
Contributor
There was a problem hiding this comment.
How easy will it be to distinguish hg vs git once we get this in bigquery? Might be useful to have some marker...
Contributor
Author
There's a A) Update the schema in BQ We can't make any changes to the existing format :/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
While implementing this patch, I learned that Perfherder actually does
not process
PERFHERDER_DATAanymore. However the TaskclusterETL isstill processing it (independently of Perfherder). So that's how we're
still able to get clone metrics out of robustcheckout.
Given that TaskclusterETL is slated to be removed, it's not great to be
adding a new feature that depends on it. However this will allow us to
get detailed clone metrics for Git in the short term, which will help
out with the migration.
Longer term, we'll need to figure out an alternative way to profile
run-taskthat doesn't rely on TaskclusterETL.