Fix console blank filtering threshold parsing - #773
Open
Fraximov wants to merge 1 commit into
Open
Conversation
Fraximov
marked this pull request as ready for review
August 19, 2026 08:03
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SampleMaxOverBlankAveragevalueFoldChangeForBlankFiltering, which the blank filter readsRoot cause
The console parser stored
Sample max / blank averageonly in the legacy property, while alignment filtering readsFoldChangeForBlankFiltering. Both default to 5, hiding the mismatch until a custom threshold is configured.Validation
dotnet test tests/MSDIAL5/MsdialCoreTestAppTests/MsdialCoreTestAppTests.csproj --configuration "Debug vendor unsupported"(5 tests passed)