Fix a bug of alignment deduplication process - #772
Merged
Conversation
Refactored the Process method to create a local list _spots from the input spots enumerable. All filtering and ordering operations are now performed on _spots. Added an early return if spotList is empty after initial LibraryID filtering and ordering.
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes an exception/incorrect behavior in the alignment annotation deduplication workflow by ensuring the input spots sequence is materialized once and by short-circuiting when there are no eligible reference-matched spots to deduplicate.
Changes:
- Materialize
spotsto a list once and reuse it across the three deduplication passes (ID / InChIKey / Name). - Add an early return when there are no reference-matched, non-“Putative” spots (prevents indexing into an empty list).
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+89
to
92
| spotList = _spots | ||
| .Where(n => n.IsReferenceMatched(_evaluator) && !n.Name.StartsWith("Putative")) | ||
| .Where(n => !n.MatchResults.Representative.Name.IsEmptyOrNull()) | ||
| .OrderByDescending(spot => spot.MatchResults.Representative.Name) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.