Fix incorrect timestamp assignment when writing inode

[EricKim27]

fix simplefs_write_inode to write the access time into disk_inode->i_atime and the modification time into disk_inode->i_mtime correctly.

After an inode has been modified or created, simplefs_write_inode(assigned to write_inode in simplefs_super_ops) is called to write the contents in the vfs inode to the relevant raw inode on disk. Because of a typo in simplefs_write_inode, i_atime gets assigned twice; once for writing access time, and again for writing modification time to it.

As a result, the raw inode metadata contains modification time on its access time field, and the modification time is never updated. Upon calling system calls like stat(), it returns modification time as access time, and an incorrect modification time(since it is never updated, and all bytes are zeroed out at mkfs, it defaults to 0, January 1st, 1970 in unix time).

Fix the assignments so access time is written to i_atime field and modification time is written to i_mtime field on on-disk inode structure.

---

Summary by cubic

Fixes incorrect timestamp assignment in simplefs_write_inode for kernel >= 6.7: write access time to disk_inode->i_atime and modification time to disk_inode->i_mtime instead of writing both to i_atime. Prevents i_mtime from being left zero so files report the correct modification time instead of 1970-01-01.

^{Written for commit d62bf18. Summary will update on new commits.}

[jserv]

Improve git commit messages per https://cbea.ms/git-commit/

[EricKim27]

@jserv Modified the commit message as requested. Thanks for your feedback.

[jserv]

Modified the commit message as requested.

Check https://cbea.ms/git-commit/ carefully and improve git commit messages to address motivations and considerations.

[EricKim27]

Modified the commit message as requested.

Check https://cbea.ms/git-commit/ carefully and improve git commit messages to address motivations and considerations.

I read the article you provided to me and improved the messages that would address my motivations and considerations. Thanks for the feedback.

[jserv]

I read the article you provided to me and improved the messages that would address my motivations and considerations. Thanks for the feedback.

Instead of changing the title of this pull request on GitHub, you should reword the commit message using git commit --amend, then force-push the updated commit.

After running gh pr checkout 92 followed by git show HEAD, I get the following one-line commit message:

fix: fix mtime from not updating correctly

This commit message violates the project's commit message guidelines.

[EricKim27]

I read the article you provided to me and improved the messages that would address my motivations and considerations. Thanks for the feedback.

Instead of changing the title of this pull request on GitHub, you should reword the commit message using git commit --amend, then force-push the updated commit.

After running gh pr checkout 92 followed by git show HEAD, I get the following one-line commit message:

fix: fix mtime from not updating correctly

This commit message violates the project's commit message guidelines

Thank you for the clarification. I misunderstood and thought you were referring to the pull request title and description.

I've amended my commit and pushed the updated commit. Sorry for the misunderstanding, and thank you for pointing it out.

[jserv]

I've amended my commit and pushed the updated commit. Sorry for the misunderstanding, and thank you for pointing it out.

Check https://cbea.ms/git-commit/ carefully and apply the rules. In particular,

• Limit the subject line to 50 characters
• Wrap the body at 72 characters

[EricKim27]

I've amended my commit and pushed the updated commit. Sorry for the misunderstanding, and thank you for pointing it out.

Check https://cbea.ms/git-commit/ carefully and apply the rules. In particular,

• Limit the subject line to 50 characters

• Wrap the body at 72 characters

@jserv I wrapped the body and shortened the subject line and made some adjustments as you suggested. Thanks for the feedback.

[jserv]

Thank @EricKim27 for contributing!

I amended the commit messages.