SC-17: wire rsync:// daemon URLs into the main sync command - #9
Merged
Conversation
rsync://host/module is now a real destination for grsync SRC... DEST, via new daemon.DialClient wired into the same pipeline.Sender every destination uses. Credentials verified against real rsync's actual behavior: username from URL/USER/LOGNAME/nobody, password from --password-file/RSYNC_PASSWORD/interactive prompt - no --password flag, matching rsync's deliberate omission to avoid ps-visibility exposure. Password resolution is lazy, only triggered on AUTHREQD, proven by test. Two bugs found: ParseRemotePath silently mis-parsed rsync://host/module as SSH syntax (host=rsync) - fixed, rejecting any "://" with a regression test. DialGreeting/DialAuth/DialModule were built around an unexported type, unreachable despite being exported - fixed via DialClient. Scope gaps (documented in README, not separate tickets): sub-path syncing within a module, pulling from an rsync:// source, max connections enforcement. Clean on native Windows and cross-compiled Linux.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
rsync://host/module is now a real destination for grsync SRC... DEST, via new daemon.DialClient wired into the same pipeline.Sender every destination uses. Credentials verified against real rsync's actual behavior: username from URL/USER/LOGNAME/nobody, password from --password-file/RSYNC_PASSWORD/interactive prompt - no --password flag, matching rsync's deliberate omission to avoid ps-visibility exposure. Password resolution is lazy, only triggered on AUTHREQD, proven by test.
Two bugs found: ParseRemotePath silently mis-parsed rsync://host/module as SSH syntax (host=rsync) - fixed, rejecting any "://" with a regression test. DialGreeting/DialAuth/DialModule were built around an unexported type, unreachable despite being exported - fixed via DialClient.
Scope gaps (documented in README, not separate tickets): sub-path syncing within a module, pulling from an rsync:// source, max connections enforcement.
Clean on native Windows and cross-compiled Linux.