[android] Build Android Embedded Swift stdlib - #582
Conversation
|
Thanks, have you tried building this yourself and using the resulting SDK bundle? |
|
Never mind, see that you did. |
|
I wonder if we should register the embedded SDK as a separate SDK bundle, like I think wasm does. That way, there is no collision between the target triples. |
Register a second Android SDK in the artifact bundle, matching the Wasm layout. The regular SDK points at swift-sdk.json and the embedded SDK points at embedded-swift-sdk.json in the same content tree, with an Android embedded toolset that enables Embedded Swift, whole-module optimization, lld, and Android linker flags.
|
Makes sense, tried that and tested locally and the SDK layout works (finnvoor@9df7edc), but I ran into an Android-specific Swift Build issue: the Android platform plugin currently overrides SDK toolsets with |
|
Yeah, that is a known issue that I just discussed with the author of that internal build logic: I will try to re-enable toolsets for Android soon, then we'll see if this works with your new config. Meanwhile, keep this pull ready with whatever config you need, don't see any new toolset added here yet? |
a82173d to
9df7edc
Compare
|
sounds good, PR updated with standalone embedded sdk. Everything should work once the toolset makes it through swift build. |
Adds an
-embeddedvariant of the android sdk.Depends on swiftlang/swift#90768 and swiftlang/swift#90886
cc @finagolfin