fix(shelf): contact-sheet a11y 加固 —— 提示横幅合并朗读 + grid region (#86) - #91
Merged
Conversation
- contactSheetHintBanner 整块 .combine 成单元素 + .isHeader + hint， VoiceOver 一次读完「这是一条可关闭的提示」；补默认 accessibilityAction 保证 combine 后双击仍能关闭（可视按钮与 VO 动作共用 dismissContactSheetHint） - contactSheetGrid 整体 .contain + label「样片小样张」，rotor 容器可跳转 - XCUI cells 契约不受影响：改动仅在 contactSheet 布局，XCUI 默认走 .list
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
概要
落实 #86 的两项代码侧加固：
contactSheetHintBanner加.accessibilityElement(children: .combine)+.accessibilityAddTraits(.isHeader)+.accessibilityHint("双击「知道了」可关闭此提示")。.combine会把子按钮动作降为 rotor 自定义操作，故补一个默认accessibilityAction，保证 hint 里说的「双击关闭」真的可用；可视按钮与 VO 动作共用新抽的dismissContactSheetHint()。contactSheetGrid整体.accessibilityElement(children: .contain)+ label「样片小样张」，VoiceOver rotor「容器」里可作为一站跳转。契约确认
cells.count契约不破：改动仅在 contactSheet 布局路径，XCUI 测试默认走.list（voxuleAppinit 在测试环境显式重置shelf.layout）。回归
swift test141 测例全过scripts/run-sim.sh --build-onlyBUILD SUCCEEDEDscripts/check-clinical-words.sh无命中遗留（需真机/人工，见 #86 勾选项）
Closes 不自动关 —— #86 留给 VoiceOver 实听后手动关。