fix(metamask): connect the granted subset on partial multichain session grants - #135
Merged
Merged
Conversation
…on grants MetaMask can approve fewer scopes than requested (no Solana account, an EVM network not added). The connector failed the entire connect on the first ungranted scope; now it connects the granted chains (still atomic for that set) and throws wallet_chain_not_supported only when nothing was granted. Found by UI nightly validation (widget requests 14 chains). Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
towanTG
marked this pull request as ready for review
July 30, 2026 11:23
towanTG
pushed a commit
that referenced
this pull request
Jul 30, 2026
Rebased onto develop: the MetaMask partial-grant half of this PR landed separately as #135 — this keeps only the WC stale-pairing fallback (client.connect with a reused pairingTopic throws on a stale relay topic; fall back to a fresh pairing so the QR flow still appears) and its tests. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
towanTG
added a commit
that referenced
this pull request
Jul 30, 2026
Rebased onto develop: the MetaMask partial-grant half of this PR landed separately as #135 — this keeps only the WC stale-pairing fallback (client.connect with a reused pairingTopic throws on a stale relay topic; fall back to a fresh pairing so the QR flow still appears) and its tests. Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com> Co-authored-by: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.