Remove stale debug console.log output (and the logger gate) - #76
Merged
Conversation
The app emitted a lot of old debugging chatter via console.log (repository context, module lifecycle, status polling, ...). It was silenced behind a gate in #74, but it's dead debug code, so remove it outright: - Delete every console.log call in src/ (console.error / console.warn, which surface real problems, are kept). Empty if/else/catch wrappers left behind are collapsed. - Remove the now-unneeded src/logger.js gate (plus its test and the index.html script tag); window.DASHBAN_DEBUG goes with it. - Drop the debug-only window.debugAboutCardStatus helper and a dead double-click stub whose only body was a log. - Strip the corresponding console.log assertions from the tests, substituting behavioral assertions where a log was a test's only check. Net ~380 fewer lines. Full suite green at 100% coverage; lint clean (965 tests). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #74. Those
console.loglines were old debugging chatter (📦 Repository context,💾 … initializing,🔄 Refreshing, etc.), so rather than keep them silenced behind a flag, this removes them outright.What changed
console.loginsrc/(60 calls across 10 modules).console.error/console.warnare kept — those surface real problems. Emptyif/else/catchwrappers left behind were collapsed.logger.jsgate added in Done-column "Archive all", coverage fix on repo switch, quieter console #74 (plus its test and the<script>tag inindex.html).window.DASHBAN_DEBUGis gone with it — there's nothing left to gate.window.debugAboutCardStatushelper, and a double-click handler stub whose only body was a log (no edit behavior existed).console.logassertions (~71 across 6 files), substituting behavioral assertions where a log was a test's only check, and deleted a few tests that existed solely to assert a log.server.js's startupconsole.logis left as-is (server-side, goes to Railway logs — not browser noise).Net ~380 fewer lines.
Testing
npm test— 965 passing.npm run test:coverage— 100% statements/branches/functions/lines across all files.npm run lint— 0 errors (7 pre-existing warnings unchanged).🤖 Generated with Claude Code
https://claude.ai/code/session_019VQjXJyM3EZPd4joy3EwaB
Generated by Claude Code