fix(watch): prevent native watcher handle leaks#165
Merged
Conversation
Codecov Report❌ Patch coverage is
@@ Coverage Diff @@
## main #165 +/- ##
=======================================
Coverage 95.26% 95.26%
=======================================
Files 124 124
Lines 61191 61261 +70
=======================================
+ Hits 58295 58362 +67
- Misses 2896 2899 +3
... and 2 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root cause
notify6 uses the natively recursiveReadDirectoryChangesWbackend on Windows. CodeGraph registered every directory separately and registered recreated paths again. Each registration owns a 16 KiB buffer and OS handles; replacing an existing path in notify leaks the previous watch state, so long-running Zed/OpenCode sessions grow monotonically.Verification
make ciWindowsCI jobScope
This is the watcher-only P0 hotfix. Windows daemon pipe/proxy lifecycle changes remain separate because they require coordinated watchdog and half-close fixes.