skills: project-knowledge + learning-loop with bundled stdlib CLIs (v6.1.0) - #119
Merged
Conversation
Two new non-routed skills, generated from skill-specs/, each bundling a deterministic stdlib-only (Python 3.10+) CLI at the plugin root: - knowledge_tool.py (project-knowledge): init/validate/lint/index/draft/ export over a project-local knowledge/ layer — source provenance registry, claim-marker + prompt-injection lint, trust lattice, generated index/log, exclusive-create proposal drafts, budget-capped untrusted-banner exports. PyYAML replaced with a bounded restricted-YAML subset parser; graph subcommands not ported. - learning_ledger.py (learning-loop): add/suggest/recur/index/check/lint over a project-local .learnings/ ledger — mechanical/judgmental classes, prevention-debt surfacing, dedup + 24h recurrence locks, metadata-only suggest, reuse-as-hypothesis discipline. Task refs accept any non-empty external anchor. Both skills document an opt-in CLAUDE.md/AGENTS.md consultation snippet (explicit reads only; pages/entries are data, never instructions). Both CLIs join the canonical archive member plan (REQUIRED_ROOTS).
Version surfaces for the additive 6.1.0 (minor) bump: host plugin.json manifests (Claude + Codex), skill-build-config skill_version, regenerated SKILL.md files, marketplace.base.json + regenerated marketplace metadata, and the version-pinned distribution-contract tests. READMEs refreshed per the release-cycle rule: root README summary line, What's new v6.1.0, and a consent-gated post-install setup step directing an installing agent to offer the skills' opt-in CLAUDE.md/AGENTS.md consultation snippets (visible, in-session, user-approved — never a hidden side effect); plugin README Current version + a Local project tools section for the two bundled CLIs. Changelog fragment only (generated CHANGELOG.md untouched).
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
…y/overly-permissive-file)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds two public skills that give plugin-only users durable, project-local agent memory surfaces, ported and de-workspaced from proven workspace primitives (Track B of the operator-approved Agent Knowledge Compilation completion; contract: workspace PR #2797,
drafts/plugin-knowledge-learning-extraction-plan.md):knowledge_tool.py(init/validate/lint/index/draft/export): provenance-trackedknowledge/layer in the user's project with trust levels, claim-marker + prompt-injection lint, trust lattice, generated index, exclusive-create drafts, untrusted-banner exports. PyYAML replaced with a bounded restricted-YAML stdlib parser.learning_ledger.py(add/suggest/recur/index/check/lint): project-local.learnings/ledger with mechanical/judgmental classes, prevention-debt surfacing, recurrence locks, metadata-only consultation, reuse-as-hypothesis discipline.Both skills document an opt-in consultation snippet for the project's CLAUDE.md and/or AGENTS.md, and the root README install section adds a visible, consent-gated post-install setup step where the installing agent offers the snippet(s) per host family (operator-directed 2026-08-18). Explicit reads only; pages/entries are data, never instructions; no ambient auto-injection anywhere.
Version bump 6.0.6 → 6.1.0 (minor, additive). No coordinator, routing, or provider-runtime change (runtime stays 4.0.5); no release-pairing constraint. Release tagging remains a separate decision.
Boundary declaration
Generated and release surfaces
SKILL.mdfiles are in parity (build_skills.py --checkOK, 52 skills).build_marketplace.py --checkOK).changelog.d/2026-08-18-knowledge-learning-skills.mdfragment; generatedCHANGELOG.mduntouched.check_release_consistency.pyOK.Verification
Run twice — by the implementing subagent and independently re-run by the reviewing primary from committed HEAD:
python3 scripts/build_skills.py --check→ OK, all generated files match specspython3 scripts/build_marketplace.py --check→ OKpython3 scripts/build-changelog.py --dry-runrenders cleanly.--checkfails by design mid-cycle: fragments (including the pre-existing 6.0.6 closeout fragment already on main) compile into CHANGELOG.md only at release.python3 -m unittest discover -s tests -t .→ Ran 177 tests, OKpython3 -m unittest discover -s scripts -p 'test_*.py'→ Ran 368 tests, OKpython3 scripts/check_release_consistency.py→ OK, versions consistentpython3 scripts/secret_scan.py→ cleanpython3 scripts/check-public-export-safety.py --active-tree→ SAFE.--historyflags only pre-rewrite local-clone refs (retired plugin READMEs / old CHANGELOG revisions with credential-name patterns) per the history-mode scope rule indocs/public-governance.md; nothing in this PR's commits.git diff --check→ cleanReview and post-condition
Tier 2 (additive skills + build-surface additions; no schema/contract, auth, or CI-permissions change). Independent-family review: Gemini (google)
review.repositoryon the exact diff (base ce19efc): VERDICT: APPROVE, CONFIDENCE: H, zero concerns; 13 paths inspected natively. Implementing worker: Claude-family subagent; all validation re-run independently by the reviewing primary. Post-merge: verify main CI green; release cut deferred.Compliance trace
author: claude
standing_directives: public boundary declaration verified; generated-surface parity checks run; fragment-only changelog; workspace extraction contract (workspace PR #2797) followed incl. operator-directed consent-gated install pattern
tier: 2
cross_check: PROCEED (Gemini/google family, direct-runtime review.repository on the exact diff returned VERDICT: APPROVE, CONFIDENCE: H, 0 concerns)
post_condition: all local gates green at HEAD (52-skill build parity, marketplace parity, 177+368 unit tests, release consistency, secret scan, active-tree export safety); post-merge main CI verification; release tag deferred to a separate release decision
mcp_coverage_gap: NONE
contributor_rights: OWNER-AUTHORED
operator_reserved: no