Add entityResolve conf option and language snippet parameter#1
Open
stromcom wants to merge 2 commits into
Open
Add entityResolve conf option and language snippet parameter#1stromcom wants to merge 2 commits into
stromcom wants to merge 2 commits into
Conversation
Mirrors two new capabilities in the main app: the Tiptap message editor's entity chip hover-card (dataLayer.conf.entityResolve) and the widget's UI-language override (data-lang), so the generated snippet stays in sync.
Both tags were cut without a matching CHANGELOG entry (two SnippetOptions default-value bugfixes). Add them retroactively so 0.4.0 doesn't sit directly above 0.3.1 with an undocumented gap in between.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConfOptions::$entityResolve— new callback option (JS-wrapped likeonNotification) resolving business-entity detail for the message editor's Tiptap chip hover-card, mirroringdataLayer.conf.entityResolvein the main app.SnippetClient::snippet(?string $language = null)— optional UI-language override, emitted asj.dataset.lang, mirroring the widget's newdata-langsupport.CHANGELOG.mdfor a0.4.0tag.Test plan
composer test— 101 tests, 160 assertions, all greencomposer ca(phpstan level max + cs:check) — no errors