Skip to content

Add regression test for JsonSerializer.Deserialize<JsonNode> respecting MaxDepth with deeply nested arrays #5

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
Copilot wants to merge 2 commits into
base: cca-eval-control
Choose a base branch
from
Draft

Add regression test for JsonSerializer.Deserialize<JsonNode> respecting MaxDepth with deeply nested arrays #5

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
64a29c5
Initial plan
Copilot May 27, 2026
91d31db
Add regression test for JsonSerializer.Deserialize<JsonNode> MaxDepth…
Copilot May 27, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions src/libraries/System.Text.Json/tests/System.Text.Json.Tests/Serialization/DomTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -210,6 +210,26 @@ public static void SerializeToNode_RespectsMaxDepth(int maxDepth)
Assert.Throws<JsonException>(() => JsonSerializer.SerializeToNode(value, options));
}

[Theory]
[InlineData(5)]
[InlineData(32)]
[InlineData(70)] // default max depth is 64
public static void DeserializeToNode_RespectsMaxDepth(int maxDepth)
{
var options = new JsonSerializerOptions { MaxDepth = maxDepth };

// Deserializing JSON at exactly the max depth should succeed.
string validJson = string.Concat(Enumerable.Repeat("[", maxDepth))
+ string.Concat(Enumerable.Repeat("]", maxDepth));
JsonNode? node = JsonSerializer.Deserialize<JsonNode>(validJson, options);
Assert.NotNull(node);

// Deserializing JSON exceeding the max depth by one should throw.
string tooDeepJson = string.Concat(Enumerable.Repeat("[", maxDepth + 1))
+ string.Concat(Enumerable.Repeat("]", maxDepth + 1));
Assert.Throws<JsonException>(() => JsonSerializer.Deserialize<JsonNode>(tooDeepJson, options));
}

public class RecursiveClass
{
public RecursiveClass? Next { get; set; }
Expand Down