Close security alerts and harden automation - #11
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Hardens security, dependency management, and CI while improving relayer portability and URL handling.
Changes:
- Replaces trailing-slash regex processing with a linear scan.
- Consolidates relayer dependencies and removes Node-specific test buffers.
- Pins CI actions and adds secret-scanning configuration.
Reviewed changes
Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
src/relayer.ts |
Adds linear trailing-slash trimming. |
src/relayer.test.ts |
Tests URL normalization. |
SECURITY.md |
Clarifies affected wallet integrations. |
relayer-proxy/src/index.test.ts |
Replaces Buffer usage with Uint8Array. |
relayer-proxy/pnpm-lock.yaml |
Removes obsolete workspace lockfile. |
CHANGELOG.md |
Records security and maintenance changes. |
.gitleaks.toml |
Configures targeted secret-scanning allowlists. |
.github/workflows/ci.yml |
Pins actions and adds Worker type-checking. |
Files not reviewed (1)
- relayer-proxy/pnpm-lock.yaml: Generated file
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| description = "Public Stellar contract addresses" | ||
| regexTarget = "match" | ||
| regexes = [ | ||
| '''C[A-Z2-7]{55}''', |
| '''(^|/)docs/migration-smart-account-kit-v0\.7\.0-rc\.2\.md$''', | ||
| ] | ||
| regexes = [ | ||
| '''(?i)(webauthn|verifier|wasm)[^\n]*[0-9a-f]{64}''', |
| '''(^|/)indexer/relayer-proxy/src/index\.test\.ts$''', | ||
| ] | ||
| regexes = [ | ||
| '''gen:\s*\(\)\s*=>.*apiKey:''', |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
git diff --checkpassed