Skip to content

Close security alerts and harden automation - #11

Merged
kalepail merged 2 commits into
mainfrom
fix/security-alert-closeout-2026-09-08
Sep 8, 2026
Merged

Close security alerts and harden automation#11
kalepail merged 2 commits into
mainfrom
fix/security-alert-closeout-2026-09-08

Conversation

@kalepail

@kalepail kalepail commented Sep 8, 2026

Copy link
Copy Markdown
Contributor

Summary

  • replace the polynomial trailing-slash expression with a linear scan
  • remove the obsolete relayer lockfile now covered by the root workspace
  • pin CI actions and add the relayer Worker type check
  • add full-history secret scanning configuration
  • clarify the remaining optional wallet dependency advisory

Verification

  • 458 SDK tests, 4 indexer tests, and 39 relayer tests passed
  • builds, ESM verification, bindings parity, pack dry run, and dependency audit passed
  • full 142-commit gitleaks scan passed
  • actionlint and git diff --check passed

Copilot AI balanced review requested due to automatic review settings September 8, 2026 19:13

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Hardens security, dependency management, and CI while improving relayer portability and URL handling.

Changes:

  • Replaces trailing-slash regex processing with a linear scan.
  • Consolidates relayer dependencies and removes Node-specific test buffers.
  • Pins CI actions and adds secret-scanning configuration.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/relayer.ts Adds linear trailing-slash trimming.
src/relayer.test.ts Tests URL normalization.
SECURITY.md Clarifies affected wallet integrations.
relayer-proxy/src/index.test.ts Replaces Buffer usage with Uint8Array.
relayer-proxy/pnpm-lock.yaml Removes obsolete workspace lockfile.
CHANGELOG.md Records security and maintenance changes.
.gitleaks.toml Configures targeted secret-scanning allowlists.
.github/workflows/ci.yml Pins actions and adds Worker type-checking.
Files not reviewed (1)
  • relayer-proxy/pnpm-lock.yaml: Generated file

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread .github/workflows/ci.yml
Copilot AI review requested due to automatic review settings September 8, 2026 19:16
@kalepail
kalepail merged commit f0dac65 into main Sep 8, 2026
7 checks passed
@kalepail
kalepail deleted the fix/security-alert-closeout-2026-09-08 branch September 8, 2026 19:19

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated 3 comments.

Files not reviewed (1)
  • relayer-proxy/pnpm-lock.yaml: Generated file

Comment thread .gitleaks.toml
description = "Public Stellar contract addresses"
regexTarget = "match"
regexes = [
'''C[A-Z2-7]{55}''',
Comment thread .gitleaks.toml
'''(^|/)docs/migration-smart-account-kit-v0\.7\.0-rc\.2\.md$''',
]
regexes = [
'''(?i)(webauthn|verifier|wasm)[^\n]*[0-9a-f]{64}''',
Comment thread .gitleaks.toml
'''(^|/)indexer/relayer-proxy/src/index\.test\.ts$''',
]
regexes = [
'''gen:\s*\(\)\s*=>.*apiKey:''',
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants