Replace manual qm31_ops in the circuit verifier with AIR-generated - #607
Replace manual qm31_ops in the circuit verifier with AIR-generated#607dancarmoz wants to merge 1 commit into
Conversation
PR SummaryMedium Risk Overview Aligns Reviewed by Cursor Bugbot for commit 7d2ca02. Bugbot is set up for automated code reviews on this repo. Configure here. |
e2c1652 to
56dc0d5
Compare
|
In what way did it change? Code quote: MULTIVERIFIER_PREPROCESSED_ROOT |
anatgstarkware
left a comment
There was a problem hiding this comment.
@anatgstarkware reviewed 8 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on az-starkware and dancarmoz).
286bf0d to
8b87a07
Compare
dancarmoz
left a comment
There was a problem hiding this comment.
@dancarmoz partially reviewed 3 files and made 1 comment.
Reviewable status: 6 of 10 files reviewed, 1 unresolved discussion (waiting on anatgstarkware and az-starkware).
crates/circuit_multiverifier/src/verify_test.rs line 61 at r1 (raw file):
Previously, anatgstarkware (anatg) wrote…
In what way did it change?
Great question :)
Amusingly enough, the circuit for the component itself is completely the same. The only thing that changed is that the relation_uses_per_row used to be
[RelationUse { relation_id: "gate", uses: 2 }]
and now it's
[RelationUse { relation_id: "Gate", uses: 2 }]
(the G became capitalized in autogeneration).
In fact almost all use cases use "Gate" rather than "gate", except eq which still used "gate".
So changed it also in this PR (to avoid having the roots and proofs changed multiple times.)
8b87a07 to
7d2ca02
Compare
az-starkware
left a comment
There was a problem hiding this comment.
@az-starkware reviewed 10 files and all commit messages, and made 1 comment.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on anatgstarkware and yuvalsw).
No description provided.