apollo_integration_tests: store the commitment infos delta in the dummy recorder - #14935
Conversation
PR SummaryLow Risk Overview A new The write-blob handler accepts Reviewed by Cursor Bugbot for commit a565ff3. Bugbot is set up for automated code reviews on this repo. Configure here. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3b33448. Configure here.
itamar-starkware
left a comment
There was a problem hiding this comment.
@itamar-starkware made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on yoavGrs).
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 0 of 3 files reviewed, 1 unresolved discussion (waiting on itamar-starkware).
crates/apollo_integration_tests/src/utils.rs line 598 at r1 (raw file):
#[derive(Debug, Default)] pub struct RecorderStats { pub num_blobs_received: AtomicUsize,
Please keep it simple.
I suggest storing the offset and a map from invalid block_number to reason.
Is there any validation that this does not cover?
3b33448 to
a565ff3
Compare
102079f to
241c722
Compare
yoavGrs
left a comment
There was a problem hiding this comment.
@yoavGrs made 1 comment.
Reviewable status: 0 of 3 files reviewed, 2 unresolved discussions (waiting on itamar-starkware).
crates/apollo_integration_tests/src/utils.rs line 619 at r2 (raw file):
// A blob is prepared before its own height's commitment completes, so // early blobs legitimately carry no commitment infos. if let Some(max_stored_height) = blob["recent_state_commitment_infos"]
I suggested validating the witnesses' heights in the blob against the stored offset.
You can report any issue in a dedicated field.


No description provided.