Skip to content

Add simplify argument to print.compare.loo#383

Open
florence-bockting wants to merge 9 commits into
masterfrom
feat/add-simplify
Open

Add simplify argument to print.compare.loo#383
florence-bockting wants to merge 9 commits into
masterfrom
feat/add-simplify

Conversation

@florence-bockting

@florence-bockting florence-bockting commented Jul 21, 2026

Copy link
Copy Markdown
Contributor

Fixes #366

Description

  • Restore simplify on print.compare.loo() so users can print the full comparison table again. Default is simplify=TRUE.
  • Background: We dropped the argument simplify in the 2.10 loo_compare redesign. User requests (see Re-add print.compare.loo(simplify=) #366) availability of old full print.

Changes

  • Add simplify = TRUE to print.compare.loo()
  • Keep p_worse / diagnostic columns under the existing p_worse control
  • Document the argument and update Examples
  • Snapshot + assertion coverage for full print
  • Added NEWS entry for the development version

This PR used AI Assistance for drafting the PR.
All changes have been reviewed by a human and adjusted if needed.

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.85%. Comparing base (1a9afd3) to head (4d69192).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #383      +/-   ##
==========================================
+ Coverage   92.70%   92.85%   +0.15%     
==========================================
  Files          31       31              
  Lines        3031     3039       +8     
==========================================
+ Hits         2810     2822      +12     
+ Misses        221      217       -4     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 21, 2026

Copy link
Copy Markdown

This is how benchmark results would change (along with a 95% confidence interval in relative change) if a70c4a3 is merged into master:

  • ✔️loo_function: 1.74s -> 1.75s [-0.43%, +1.54%]
  • ✔️loo_matrix: 1.73s -> 1.73s [-1.27%, +0.29%]
    Further explanation regarding interpretation and methodology can be found in the documentation.

@florence-bockting
florence-bockting marked this pull request as ready for review July 21, 2026 08:17
@florence-bockting
florence-bockting requested a review from jgabry July 21, 2026 08:17

@jgabry jgabry left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks. I made a couple of trivial change requests.

Comment thread NEWS.md Outdated
Comment thread tests/testthat/test_compare.R Outdated
Comment thread R/loo_compare.R
Comment thread tests/testthat/test_compare.R Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-add print.compare.loo(simplify=)

3 participants