Do not fail withdrawal cycle on unresolved consolidation target - #799
Open
cyc60 wants to merge 1 commit into
Open
Do not fail withdrawal cycle on unresolved consolidation target#799cyc60 wants to merge 1 commit into
cyc60 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
get_pending_consolidationsraisedValueErrorwhen a pending consolidation's source was a vault validator but the target index was not found among the vault's consensus validators. The only realistic way to reach that state is a local-indexing race: the consolidation submission flow already guarantees targets are vault-registered validators, but the withdrawal task builds its validator set from the local database, which can lag behind on-chain registration events (restart, event-scan lag).The raise propagated out of the withdrawal subtask and aborted the entire
ValidatorTask.process_blockiteration — validator registration and withdrawals both — every block until the database caught up, turning a transient sync gap into a near-silent stall of the whole validator pipeline.The entry is now appended with a warning instead of raising. Appending (rather than skipping) is deliberate: every consumer only performs membership checks or source-index lookups —
_calculate_validators_exits_amountreads source indexes only, exit selection uses target indexes solely in set-membership checks where a non-vault index is inert, andConsolidationManageruses the target index only as a dict key — so keeping the entry preserves the source validator's exclusion from exit selection and assets accounting during the sync window.