Disable graph reconnecting session, bump v0.13.4 - #199
Merged
Conversation
cyc60
approved these changes
Jul 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Disable the gql
reconnecting=Truesession inGraphClient, switching to a plain non-reconnectingAsyncClientSession.reconnecting=Trueprovides no benefit forAIOHTTPTransport(request/response HTTP — there is no persistent connection to reconnect), and itsclose_async()teardown cancels the background_connection_looptask without awaiting it. That race orphans the underlyingaiohttp.ClientSession, producing intermittent "Unclosed client session" warnings. Query-level robustness is already provided byretry_gql_errorsinrun_query.With
reconnecting=False,close_async()reduces totransport.close()(which drains aiohttp deterministically), so cleanup is deterministic with no orphaned sessions. Same happy-path behavior and same query-level retries.Also dropped
retry_execute=False— it is only consumed byReconnectingAsyncClientSessionand is a no-op on the non-reconnecting path.Bumped version to
v0.13.4.