-
Notifications
You must be signed in to change notification settings - Fork 3
refactor: earn flow + remove xstate/store #551
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
petar-omni
wants to merge
56
commits into
main
Choose a base branch
from
feat/earn-effect-atom-poc
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
56 commits
Select commit
Hold shift + click to select a range
8f6710c
feat(widget): add effect atom earn flow
petar-omni 15d72af
refactor(widget): replace xstate stores with effect atoms
petar-omni 3127f0d
fix(widget): stabilize earn option resolution
petar-omni 5dac944
feat: borrow init
petar-omni 2110846
feat: temp
petar-omni 90a2b21
fix(widget): stabilize earn atom subscriptions
petar-omni b2043f0
feat: schema decoding, query to atoms migration
petar-omni 3c5bfdc
build(typescript): migrate to typescript 7
petar-omni 67eb76f
refactor(widget): migrate runtime state to effect atoms
petar-omni 0d6ed5f
refactor(widget): narrow published type declarations
petar-omni 98e4c72
chore(repo): align workspace tooling configuration
petar-omni 7f4ea37
refactor(widget): reorganize modules by ownership
petar-omni d00f44e
refactor(widget): simplify borrow wallet state projection
petar-omni 3870423
refactor(widget): unify transaction workflow execution
petar-omni 3dabf4a
fix(widget): stabilize transaction workflow execution
petar-omni 9714f3d
fix(widget): stabilize transaction workflow atom identity
petar-omni df4abba
test(widget): stabilize asynchronous hook tests
petar-omni 299528b
feat(widget): isolate runtime state by wallet scope
petar-omni 533df27
feat(widget): establish scoped wallet runtime
petar-omni 17b8feb
feat(widget): add scoped headless solana runtime
petar-omni 2771fb0
feat(widget): make wallet service config authoritative
petar-omni e5a8a8b
feat(widget): own external provider synchronization
petar-omni 835a450
feat(widget): publish canonical wallet state
petar-omni d1b6eb5
feat(widget): move wallet lifecycle policies
petar-omni d10d4fb
feat(widget): route commands from wallet state
petar-omni a77564b
feat(widget): integrate dynamic solana membership
petar-omni e43ea7d
refactor(widget): remove legacy wallet ownership
petar-omni 16bd0ab
refactor(widget): simplify wallet service bootstrap
petar-omni 9d4d279
refactor(widget): remove internal barrel exports
petar-omni 6858258
feat(widget): enforce single widget instance lifecycle
petar-omni 44726d1
refactor(widget): remove wallet reconnect serialization
petar-omni 14473ae
chore(widget): enforce classic flow architecture
petar-omni b83fe8b
feat(widget): establish classic transaction flow core
petar-omni 5e76122
feat(widget): add classic flow effect atom facade
petar-omni da95f91
feat(widget): migrate enter transaction flow
petar-omni b13cc54
feat(widget): migrate exit and manage transaction flows
petar-omni 1cc25fa
feat(widget): migrate activity resume flow lifetime
petar-omni d13bc31
refactor(widget): isolate classic workflow handoff
petar-omni a3d26ae
refactor(widget): complete classic flow cutover
petar-omni f86f6d7
refactor(widget): deepen classic flow atom boundary
petar-omni e68f426
refactor(widget): scope classic flow by session
petar-omni 8f8bd72
fix(widget): harden classic flow session boundaries
petar-omni 5ad1c12
fix(widget): key flow lifecycle by route entry
petar-omni 1b7fb13
refactor(widget): align classic flow lifetimes
petar-omni 49c5f22
fix(widget): align action requests and workflow lifetimes
petar-omni 364d5cc
refactor(widget): separate transaction flow ownership
petar-omni 77802a3
refactor(widget): expose workflows through scoped atoms
petar-omni 5ab29a2
refactor(widget): centralize authoritative resources
petar-omni 59beec8
chore(widget): merge main into effect atom branch
petar-omni 4baeb74
feat(widget): resolve earn selection and readiness
petar-omni 768b66c
ci(release): add canary npm publishing
petar-omni d69dcf9
refactor(widget): adopt effect datetime
petar-omni f4ab711
refactor(widget): disallow nested ternaries
petar-omni f41ad22
fix(widget): correct borrow position data
petar-omni ae0dc50
feat(lint): enforce widget architecture rules
petar-omni 1ac27c3
refactor(widget): move feature logic into atom-owned facades
petar-omni File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
There are no files selected for viewing
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔒 Agentic Security Review
Severity: HIGH
The canary publish job executes
curl https://mise.run | ... shdirectly, which runs mutable remote script content in a publish-capable CI path. This creates a trust-boundary break where compromise of the remote script source or transit path can execute arbitrary commands during release.Impact: An attacker controlling that install script path could tamper with build/publish steps and ship malicious package artifacts under a trusted namespace.
Reviewed by Cursor Security Reviewer for commit ae0dc50. Configure here.