Skip to content

ROX-33036: add mount related operations#1059

Draft
Molter73 wants to merge 1 commit into
mainfrom
mauro/ROX-33036/track-mount
Draft

ROX-33036: add mount related operations#1059
Molter73 wants to merge 1 commit into
mainfrom
mauro/ROX-33036/track-mount

Conversation

@Molter73

@Molter73 Molter73 commented Jul 9, 2026

Copy link
Copy Markdown
Member

Description

This was originally going to be about adding just lsm/sb_mount, however while adding this hook it became pretty clear we needed lsm/sb_umount and lsm/move_mount for a comprehensive implementation and it really didn't add too much code, so they are all added in.

These operations are not currently intended to be forwarded via gRPC, they only trigger inode tracking related behavior (scans on new/moved mounts, inode map cleanups on moved/unmounted directories).

The move mount operation shares quite a bit of similarities with rename, so there is a bit of refactoring mixed in so they can be reused while keeping the code clean.

TODO: add integration tests.

Checklist

  • Patch has a change log entry OR does not need one.
  • Investigated and inspected CI test results
  • Updated documentation accordingly

Automated testing

  • Added unit tests
  • Added integration tests
  • Added regression tests

If any of these don't apply, please comment below.

Testing Performed

TODO(replace-me)
Use this space to explain how you tested your PR, or, if you didn't test it, why you did not do so. (Valid reasons include "CI is sufficient" or "No testable changes")
In addition to reviewing your code, reviewers must also review your testing instructions, and make sure they are sufficient.

For more details, ref the Confluence page about this section.

@coderabbitai

coderabbitai Bot commented Jul 9, 2026

Copy link
Copy Markdown

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yml

Review profile: CHILL

Plan: Enterprise

Run ID: dbf1204c-c0bd-4b12-8a0e-f62f0bcae498

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch mauro/ROX-33036/track-mount

Comment @coderabbitai help to get the list of available commands.

@codecov-commenter

codecov-commenter commented Jul 9, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 0% with 147 lines in your changes missing coverage. Please review.
✅ Project coverage is 32.38%. Comparing base (88c0d04) to head (b15f103).

Files with missing lines Patch % Lines
fact/src/event/mod.rs 0.00% 103 Missing ⚠️
fact/src/host_scanner.rs 0.00% 44 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1059      +/-   ##
==========================================
- Coverage   33.22%   32.38%   -0.84%     
==========================================
  Files          21       21              
  Lines        2971     3048      +77     
  Branches     2971     3048      +77     
==========================================
  Hits          987      987              
- Misses       1981     2058      +77     
  Partials        3        3              

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

This was originally going to be about adding just `lsm/sb_mount`,
however while adding this hook it became pretty clear we needed
`lsm/sb_umount` and `lsm/move_mount` for a comprehensive implementation
and it really didn't add too much code, so they are all added in.

These operations are not currently intended to be forwarded via gRPC,
they only trigger inode tracking related behavior (scans on new/moved
mounts, inode map cleanups on moved/unmounted directories).

The move mount operation shares quite a bit of similarities with rename,
so there is a bit of refactoring mixed in so they can be reused while
keeping the code clean.

TODO: add integration tests.
@Molter73
Molter73 force-pushed the mauro/ROX-33036/track-mount branch from 3cc1980 to b15f103 Compare July 20, 2026 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants