feature(vpn): onboard gateway#1417
Open
Manuelvaas wants to merge 11 commits into
Open
Conversation
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
|
This PR was marked as stale after 7 days of inactivity and will be closed after another 7 days of further inactivity. If this PR should be kept open, just add a comment, remove the stale label or push new commits to it. |
Manuelvaas
force-pushed
the
feature/onboard-vpn-gateway
branch
from
458d051 to
f0fe08f
Compare
marceljk
reviewed
Jul 14, 2026
Comment on lines
+144
to
+158
| for _, route := range tunnel.BgpStatus.Get().Routes { | ||
| if route.Network != "" { | ||
| routeString += fmt.Sprintf("Network: %s; ", route.Network) | ||
| } | ||
| if route.Origin != "" { | ||
| routeString += fmt.Sprintf("Origin: %s; ", route.Origin) | ||
| } | ||
| if route.Path != "" { | ||
| routeString += fmt.Sprintf("Path: %s; ", route.Path) | ||
| } | ||
| if route.PeerId != "" { | ||
| routeString += fmt.Sprintf("PeerId: %s; ", route.PeerId) | ||
| } | ||
| routeString += fmt.Sprintf("Weight: %d\n", route.Weight) | ||
| } |
Contributor
There was a problem hiding this comment.
Didn't find yet a valid configuration to get this output, but I think it would be more readable, when there is always a new line instead of a semicolon. A row doesn't need to be always only one single line, it can have also more than one line
Contributor
There was a problem hiding this comment.
But we can also discuss about it in a private chat
relates to STACKITCLI-353
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Co-authored-by: Marcel Jacek <72880145+marceljk@users.noreply.github.com>
Manuelvaas
force-pushed
the
feature/onboard-vpn-gateway
branch
from
a3da9dc to
3215197
Compare
Merging this branch changes the coverage (1 decrease, 10 increase)
Coverage by fileChanged files (no unit tests)
Please note that the "Total", "Covered", and "Missed" counts above refer to code statements instead of lines of code. The value in brackets refers to the test coverage of that file in the old version of the code. Changed unit test files
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
relates to STACKITCLI-353
Checklist
make fmtmake generate-docs(will be checked by CI)make test(will be checked by CI)make lint(will be checked by CI)