Fix fish >= 4.8 shared bindings; add x/X linewise selections - #18
Open
nomoruni wants to merge 1 commit into
Open
Fix fish >= 4.8 shared bindings; add x/X linewise selections#18nomoruni wants to merge 1 commit into
nomoruni wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Two independent fixes, split into separate commits:
1. Fix bindings source dumped at startup on fish >= 4.8
Fish 4.8 changed
__fish_shared_key_bindingsto print its code instead ofexecuting it (so that
bindattributes the bindings to the caller). The plugincalled it directly, so on every startup the whole binding list was printed to
the terminal instead of applied.
Fixed the same way fish's own
fish_vi_key_bindingsdoes it:Fixes #16
2. Implement x / X linewise selections
extending instead of recomputing from the cursor
Adds select_line / extend_line_up to fish_helix_command.fish and binds
them in fish_helix_key_bindings.fish (removes the corresponding FIXMEs).
Fixes #17
Testing
Tested interactively on fish 4.8.1 / Arch Linux: