Make translation opt-in - #78
Merged
Merged
Conversation
srcrip
marked this pull request as ready for review
July 27, 2026 21:30
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves: #56
high level:
Limits LiveToast translation to its four built-in connection-notice strings, and only when an application configures gettext_backend. Messages and titles supplied through send_toast/3, put_toast/4, or custom connection-notification copy now pass through unchanged, so applications own their translation context and arbitrary toast content is never sent to Gettext.
Basically, I think it was a mistake in #13 to add these translation capabilities to the regular put_toast functions. it really should have only ever let you easier translate those built in connection lost strings. This is technically a breaking change, so sorry but its better this way.